expose isPresent ios implementation #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
mvanbeusekom
requested changes
Feb 16, 2024
geocoding_ios/lib/geocoding_ios.dart
Outdated
Comment on lines
62
to
71
| try { | ||
| final isPresent = await _channel.invokeMethod( | ||
| 'isPresent', | ||
| ); | ||
|
|
||
| return isPresent; | ||
| } on PlatformException catch (e) { | ||
| _handlePlatformException(e); | ||
| rethrow; | ||
| } |
There was a problem hiding this comment.
Wouldn't it be easier / faster to simply return true in this method and skip the whole native implementation?
mvanbeusekom
requested changes
Feb 16, 2024
geocoding_ios/pubspec.yaml
Outdated
There was a problem hiding this comment.
The dependency on the geocoding_platform_interface should be updated to version 3.2.0 to enforce the implementation of the isPresent() method.
If we don't do so, this might result in analysis warnings when developers are compiling against an older version of the geocoding_platform_interface (which was the case for me :P).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements isPresent iOS (#194)
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.