Fix removeCacheFile

[SmartVive]

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

fix removeCacheFile

⤵️ What is the current behavior?

removeCacheFile not working. because file dir is wrong.

🆕 What is the new behavior (if this is a feature change)?

removeCacheFile is working.

💥 Does this PR introduce a breaking change?

no

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

• All projects build
• Follows style guide lines (code style guide)
• Relevant documentation was updated
• Rebased onto current develop

[snoopdoggy322]

@martijn00 pls merge it, clearing files doesn't work at all

[martijn00]

I'm not sure this is correct. The old code only creates a reference to the file, and this code actually creates the file. So the check for the file will always be true, which is not correct.

Might there be a problem in your own code?

[snoopdoggy322]

@martijn00
But the file reference leads to old code that never points to the actual file, resulting in a constant accumulation of files in the cache.

Is there a possible mistake in the name of the method itself? For example, the _fileExists method uses the same fileSystem.createFile to check for the existence of a file.

[SmartVive]

test code:

    final oldFile = io.File(cacheObject.relativePath);
    print("oldFilePath:${oldFile.path},isExist:${await oldFile.exists()}");

    final newfile = await fileSystem.createFile(cacheObject.relativePath);
    print("newFilePath:${newfile.path},isExist:${await newfile.exists()}");
    
    final testfile = await fileSystem.createFile("test");
    print("testFilePath:${testfile.path},isExist:${await testfile.exists()}");

result:

oldFilePath:340d19b0-7b3d-11ef-ba62-6f906510429c.file,isExist:false

newFilePath:/data/user/0/xxx.xxx.xxx/cache/response/340d19b0-7b3d-11ef-ba62-6f906510429c.file,isExist:true

testFilePath:/data/user/0/xxx.xxx.xxx/cache/response/test,isExist:false

1.cacheObject.relativePath is file name. not file path
2.fileSystem.createFile("test") file will not be created

@martijn00

[wyyadd]

Same problem. File will never be deleted.

final file = io.File(cacheObject.relativePath);
 if (file.existsSync()) {
}

Previous code will fix that.

final file = await fileSystem.createFile(cacheObject.relativePath);

[martijn00]

Reference #387

[martijn00]

@SmartVive can you add some more tests to make sure the behaviour is verified?

[SmartVive]

@martijn00 Do you mean adding unit tests? I did, but I'm not good at them.