Add pagination members to struct via macro #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 20, 2024
tluijken
approved these changes
Aug 22, 2024
| @@ -38,27 +36,15 @@ use stellar_rust_sdk_derive::Pagination; | |||
| /// | |||
| /// ``` | |||
| /// | |||
| #[derive(Default, Pagination)] | |||
| #[pagination] | |||
kevin-pease
force-pushed
the
82-pagination-members
branch
from
705d5d7 to
9dd913f
Compare
kevin-pease
force-pushed
the
82-pagination-members
branch
from
9dd913f to
9e3486e
Compare
tluijken
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Fixes #81, #82 and #66.
Changes the derive macro for pagination functionality to an attribute macro. In addition to injecting the 3 methods for pagination, the macro now also injects the 3 required fields. Updates all implementations of this macro.
Since a
Paginatabletrait is no longer necessary and undesirable as per issue #81, this is also removed.Adds documentation and comments.
Note: since the macro is named specifically
stellar_rust_sdk_derivebut is now an attribute macro, we should probably change the name accordingly.📝 Links to relevant issues/docs
https://users.rust-lang.org/t/solved-derive-and-proc-macro-add-field-to-an-existing-struct/52307/4
https://doc.rust-lang.org/reference/procedural-macros.html#attribute-macros
🤔 Checklist before submitting