Effects for liquidity pools endpoint #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonardTibben
force-pushed
the
effects-for-liquidity-pools
branch
from
963579c to
67f0fe4
Compare
ejorritsma
suggested changes
Feb 13, 2024
comment test tests fixes
LeonardTibben
force-pushed
the
effects-for-liquidity-pools
branch
from
bc7e1cd to
501add6
Compare
ejorritsma
suggested changes
Feb 14, 2024
tluijken
requested changes
Feb 26, 2024
| use crate::BuildQueryParametersExt; | ||
|
|
||
| #[derive(Default)] | ||
| pub struct EffectsForLiquidityPoolRequest { |
There was a problem hiding this comment.
Ik mis hier nog documentatie rondom de EffectsForLiquidityPoolRequest zelf.
Net als bij SingleAccountRequest<I>, zie je dat Eline niet alleen documentatie heeft toegevoegd, maar ook referenties naar de Horizon API Endpoint, code examples die getest worden met cargo test (doctest).
Dit zou eigenlijk standaard voor alle publieke structs moeten zijn.
Zo mis ik dit ook voor EffectsForAccountRequest bijv. Zit niet in deze PR, maar mag er wel bij wat mij betreft.
tluijken
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.