Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Offer Endpoint 2 #50

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Single Offer Endpoint 2 #50

merged 1 commit into from
Apr 29, 2024

Conversation

kevin-pease
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Adds the endpoint for single Offers requests. Includes documentation and unit tests. Doesn't include the other Offers endpoints yet, to keep this PR's size manageable. These endpoints will be included in future PR's.

This PR is derived from the previously created PR.

⤵️ What is the current behavior?

No Offers endpoints are implemented yet.

🆕 What is the new behavior (if this is a feature change)?

The endpoint for single offers is implemented.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current main

@kevin-pease kevin-pease changed the title Copy code from original offer branch Single Offer Endpoint 2 Apr 29, 2024
Copy link
Contributor

@LeonardTibben LeonardTibben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@LeonardTibben LeonardTibben merged commit cb9afdb into develop Apr 29, 2024
2 checks passed
@kevin-pease kevin-pease deleted the single-offer-endpoint2 branch July 11, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants