Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enableCopy #63

Merged
merged 10 commits into from
Sep 1, 2023
Merged

feat: add enableCopy #63

merged 10 commits into from
Sep 1, 2023

Conversation

lcschy
Copy link
Contributor

@lcschy lcschy commented Aug 30, 2023

Description

  • Adds enableCopy and copyIconColor options to the TextElement
  • Adds copy and check icons to package Resources for both SPM and CocoaPods
  • Change the way readOnly works from disabling user interaction to an approach using becomeFirstResponder
    • Effect is the same, can't edit.
    • Reason for changing is that if userInteraction is disabled you can't interact w/ the copy button.

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

Simulator Screenshot - iPhone 14 Pro - 2023-08-31 at 13 35 22

Simulator Screenshot - iPhone 14 Pro - 2023-08-31 at 13 35 13

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@lcschy lcschy changed the title Eng 4307 feat: add enableCopy Aug 31, 2023
@lcschy lcschy marked this pull request as ready for review August 31, 2023 16:49
@lcschy lcschy requested a review from a team as a code owner August 31, 2023 16:49
@lcschy lcschy merged commit 2e7e0bf into master Sep 1, 2023
3 checks passed
@lcschy lcschy deleted the eng-4307 branch September 1, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants