Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type conversion when submitting element values #66

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Conversation

lcschy
Copy link
Contributor

@lcschy lcschy commented Sep 4, 2023

Description

  • Adds the getValueType option for converting element value types before sending to API.

  • ⚠️ BREAKING CHANGE:

    • The month and year methods of CardExpirationDateUITextField will now send Int values to the API.
    • This will cause any tokenization response w/ these values to also return Int.

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@lcschy lcschy marked this pull request as ready for review September 4, 2023 21:44
@lcschy lcschy requested a review from a team as a code owner September 4, 2023 21:44
@lcschy lcschy merged commit 74ee517 into master Sep 6, 2023
3 checks passed
@lcschy lcschy deleted the eng-5296 branch September 6, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants