fix: ignore casing when checking bt-expose-raw-proxy-response header #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcschy
commented
Aug 9, 2024
| @@ -73,12 +73,16 @@ private func encodeParamsToFormUrlEncoded(_ formParams: [String: Any]) -> String | |||
|
|
|||
| struct HttpClientHelpers { | |||
| static func executeRequest(method: HttpMethod, url: String, payload: [String: Any]?, config: Config?, completion: @escaping ((_ request: URLResponse?, _ data: JSON?, _ error: Error?) -> Void)) -> Void { | |||
| guard let url = URL(string: url) else { | |||
| guard var components = URLComponents(string: url), components.scheme != nil else { | |||
There was a problem hiding this comment.
I guess this changed w/ OS version? Super weird lol.
Somehow to it #$@$%23!@%23%5E*&*(()-=0__+badurl?!?! is a valid URL, had to make it more complex.
lcschy
commented
Aug 9, 2024
| let shouldExposeRawProxyResponse = (response as? HTTPURLResponse)? | ||
| .allHeaderFields | ||
| .contains { (key, _) in | ||
| (key as? String)?.lowercased() == "bt-expose-raw-proxy-response" |
There was a problem hiding this comment.
Lower casing header key.
lcschy
commented
Aug 9, 2024
| // doubleTap doesn't work because it has a certain delay to display the menu | ||
| phoneNumberTextField.tap() | ||
| phoneNumberTextField.tap() | ||
| phoneNumberTextField.press(forDuration: 1) |
There was a problem hiding this comment.
This seemed more reliable than the double tap on new simulator.
lcschy
commented
Aug 9, 2024
| @@ -448,7 +448,7 @@ final class ProxyServiceTests: XCTestCase { | |||
| do { | |||
| let token = try result.get().body.data!.value as! [String: Any] | |||
|
|
|||
| XCTAssertEqual(token["textFieldRef"] as! String, "https://echo.basistheory.com/get") | |||
| XCTAssertEqual(token["textFieldRef"] as! String, "http://echo.basistheory.com/get") | |||
There was a problem hiding this comment.
This was a change directly on the echo server, so had to change here to match.
lcschy
changed the title
kevinperaza
reviewed
Aug 9, 2024
.github/scripts/integration-test.sh
Outdated
| @@ -27,5 +27,5 @@ xcodebuild clean test \ | |||
| -project ./IntegrationTester/IntegrationTester.xcodeproj \ | |||
| -scheme IntegrationTester \ | |||
| -configuration Debug \ | |||
| -destination platform="iOS Simulator,OS=16.1,name=iPhone 14 Pro" \ | |||
| -destination platform="iOS Simulator,OS=latest,name=iPhone 15 Pro" \ | |||
There was a problem hiding this comment.
This is fine, but shouldn't we be testing against the lowest version we support?
There was a problem hiding this comment.
I went as low as possible w/ the machine/xcode version combo rn.
We can look into what it takes to have 'lesser' iOS versions later on
kevinperaza
previously approved these changes
Aug 9, 2024
kevinperaza
approved these changes
Aug 9, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing required outside of automated testing?
Screenshots (if appropriate):
Rollback / Rollforward Procedure
Reviewer Checklist