Networkx -> Rustworkx Migration #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to
rustworkxwill give us more headroom. Especially for larger problems and harder isomorphism problems (this will happen as models perform better and require our "full equivalence" test more).Also includes some minor fixes that makes this more complete:
.decompose()didn't use to reflect the current state of a graph. If manipulations were made to the graph, then.decompose()would return a wrong graph._init_predicatesfor example.fully_specify()for Gripper, brings the "typing" propositions from the initial scene to the goal scene. Could have, but didn't, affected numbers.ReducedSceneGraphandReducedProblemGraph).distance(),.is_fully_specified())