Skip to content

Conversation

@eanorige
Copy link
Member

@eanorige eanorige commented May 1, 2025

The initial project uses make for test running. The python ecosystem has pytest as a testing framework and tox for managing virtual environments. This PR attempts to start the migration to these by converting one test file to use these tools.

@eanorige eanorige requested a review from Copilot May 1, 2025 22:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the test infrastructure from make-based test running to using pytest and tox. Key changes include the addition of a tox.toml configuration file, converting one test file to use the new testing framework, and updating pyproject.toml with dependency and Python version changes.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tox.toml New tox configuration file defining environments for tests, docs, and formatting
tests/test_array.py Updated and expanded tests for array and record behavior
tests/cli.py Added CLI parsing helpers and test decorators
pyproject.toml Updated project metadata and dependencies
conftest.py Added a pytest option for quick test runs
Files not reviewed (1)
  • tests/README: Language not supported
Comments suppressed due to low confidence (1)

tests/cli.py:25

  • [nitpick] The parameter name 'etp' is ambiguous. Consider renaming it to a more descriptive name such as 'should_pass' to improve clarity.
def __init__(self, etp, msg):

description = "build documentation"
basepython = ["py312"]
skip_install = true
deps = "sphinx>=4"
Copy link

Copilot AI May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] For consistency with other environments that use lists for dependencies, consider changing the docs environment deps to a list format (e.g., deps = ["sphinx>=4"]).

Suggested change
deps = "sphinx>=4"
deps = ["sphinx>=4"]

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant