Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #35

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Logging #35

merged 5 commits into from
Feb 6, 2025

Conversation

sprivite
Copy link
Collaborator

@sprivite sprivite commented Feb 5, 2025

No description provided.

@sprivite sprivite requested a review from a-hartens as a code owner February 5, 2025 15:29
Copy link
Collaborator

@a-hartens a-hartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you look at the changes i've made? are you happy with this? i have moved creating of a logger to a util file because it ~dozen lines of code that we would have to add at the top of every file. having removed this, we just need to import this function and use as needed...

@sprivite sprivite merged commit 41f2767 into main Feb 6, 2025
1 check passed
@sprivite sprivite deleted the logging branch February 6, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants