Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measurement change pt #52

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

measurement change pt #52

wants to merge 3 commits into from

Conversation

sprivite
Copy link
Collaborator

@sprivite sprivite commented Mar 5, 2025

Implements measurement change phenotype

@sprivite sprivite requested a review from a-hartens as a code owner March 5, 2025 14:23
@sprivite
Copy link
Collaborator Author

sprivite commented Mar 5, 2025

need to discuss:

  1. what to do when measurements are on same date (phenotype does not have intra-day resolution)
  2. different kinds of return dates. return_date = 'second' just means second event, but many pairs of events might satisfy the filters and which of these do we return? right now, all are returned

@a-hartens
Copy link
Collaborator

  1. measurements on the say day should be handled by the measurementpheontype; we either do daily_mean/daily_median or no value aggregation. However, we are not able to pick up lab changes occurring on the same day. so currently we do not support time stamps.
  2. return_date is the concept of multiple events which fulfill your criteria, and which one you should return the date of. There is something else happening with phenotypes that require multiple events to become a positive event e.g. multiple occurrences, lab change, and computation graph phentoypes (logic, score, arithmetic). For these we have been using return_date first, last, but should consider having a new keyword arguement. component_date_select, return_date stays the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants