Feat/improved agent #31

Baz00k · 2026-01-15T09:27:33Z

No description provided.

Copilot

Pull request overview

This PR introduces a major architectural change to the agent system, replacing the draft-based workflow with a Virtual File System (VFS) that stages changes before applying them. The agent now works with file diffs instead of text drafts, and the reviewer provides feedback through structured comments.

Changes:

Introduced VFS service for staging file modifications and generating diffs
Refactored agent workflow to use writer/reviewer tools with VFS integration
Added theme system with multiple UI themes and diff viewer
Implemented session resume/retry functionality
Enhanced web fetch with PDF support and binary content detection

Reviewed changes

Copilot reviewed 54 out of 55 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/services/vfs.ts	New VFS service for staging file changes and generating diffs
src/services/agent.ts	Refactored agent to use VFS-based workflow with session resume
src/tui/hooks/useAgent.ts	Changed to global state with useSyncExternalStore
src/tui/theme/index.ts	New theme system with GitHub Dark, Monokai, and Dracula themes
src/tui/components/*	New DiffReviewModal, DiffView, Sidebar, and updated components
src/tools/vfs.ts	New VFS-based file manipulation tools
src/tools/review.ts	New reviewer tools for commenting and approving/rejecting
src/services/prompts.ts	Updated prompts for VFS-based workflow
src/services/web.ts	Added PDF extraction and binary content detection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T16:39:57Z

src/tui/hooks/useAgent.ts

+let globalState: AgentState = { ...initialAgentState };
+const listeners = new Set<() => void>();
+
+let globalSession: {
+    submitUserAction: (action: UserAction) => Effect.Effect<void, unknown>;
+    cancel: () => Effect.Effect<void>;
+    fiber: Fiber.RuntimeFiber<void, unknown> | null;
+} | null = null;
+
+let globalLastRunOptions: RunOptions | null = null;


Using global mutable state in React hooks creates race conditions when multiple instances exist or components unmount/remount. This violates React's rules of hooks and can lead to memory leaks. Consider using React Context or a proper state management solution instead of module-level globals.

Copilot · 2026-01-16T16:39:57Z

src/services/agent.ts

+                const step = Effect.fn("step")(function* (
+                    currentCycle: number,
+                ): Effect.fn.Return<


The step function is recursive (line 578: return yield* step(cycle) and line 608) without a clear base case at the function signature level. While there is an iteration limit check at line 409, the recursive pattern makes the code harder to follow. Consider refactoring to use an iterative loop with explicit continuation conditions.

Copilot · 2026-01-16T16:39:57Z

src/services/user-dirs.ts

    }

-    return yield* Effect.fail(new UserDirError({ message: "Could not determine config directory" }));
+    return yield* new UserDirError({ message: "Could not determine config directory" });


This changed from Effect.fail(new UserDirError(...)) to yield* new UserDirError(...). The new syntax is incorrect - you cannot yield from a Data.TaggedError instance. This will cause a runtime error. Should be return yield* Effect.fail(new UserDirError(...)).

Copilot · 2026-01-16T16:39:57Z

src/services/user-dirs.ts

    }

-    return yield* Effect.fail(new UserDirError({ message: "Could not determine data directory" }));
+    return yield* new UserDirError({ message: "Could not determine data directory" });


Same issue as line 27 - incorrect Effect error handling syntax. Should be return yield* Effect.fail(new UserDirError(...)).

Copilot · 2026-01-16T16:39:58Z

src/services/project-files.ts

+                    return yield* new FileReadError({
+                        cause: "Access denied",
+                        message: `Access denied: ${resolved} is outside of ${cwd}`,
+                    });


Incorrect Effect error handling syntax - cannot yield from error constructor. Should be return yield* Effect.fail(new FileReadError(...)).

Suggested change

return yield* new FileReadError({

cause: "Access denied",

message: `Access denied: ${resolved} is outside of ${cwd}`,

});

return yield* Effect.fail(

new FileReadError({

cause: "Access denied",

message: `Access denied: ${resolved} is outside of ${cwd}`,

}),

);

Copilot · 2026-01-16T16:39:58Z

src/services/agent.ts

+                        return yield* new AgentStreamError({
+                            message: "Prompt is required for new sessions",
+                            cause: new Error("Missing prompt"),
+                        });


Incorrect Effect error handling - yielding from error constructor instead of Effect.fail. Should be return yield* Effect.fail(new AgentStreamError(...)).

Suggested change

return yield* new AgentStreamError({

message: "Prompt is required for new sessions",

cause: new Error("Missing prompt"),

});

return yield* Effect.fail(

new AgentStreamError({

message: "Prompt is required for new sessions",

cause: new Error("Missing prompt"),

}),

);

Copilot · 2026-01-16T16:39:58Z

src/providers/antigravity/constants.ts

 export const ANTIGRAVITY_ENDPOINT_SANDBOX = "https://daily-cloudcode-pa.sandbox.googleapis.com";

-export const ANTIGRAVITY_DEFAULT_ENDPOINT = ANTIGRAVITY_ENDPOINT_DAILY;
+export const ANTIGRAVITY_DEFAULT_ENDPOINT = ANTIGRAVITY_ENDPOINT_SANDBOX;


Changed from DAILY to SANDBOX endpoint. This appears to be a configuration change that should not be committed to the main branch as it affects the production behavior. Consider using environment variables for endpoint selection.

Copilot · 2026-01-16T16:39:58Z

src/index.ts

+const command = Command.make("jot", {}, () =>
+    Effect.tryPromise({
+        try: () => startTUI(),
+        catch: (error) => new TUIStartupError({ cause: error, message: `Failed to start TUI: ${error}` }),
+    }),
+).pipe(
+    Command.withSubcommands([writeCommand, configCommand, antigravityCommand]),


The default command now always starts the TUI. The removed auth command is no longer accessible. If this is intentional, ensure users have an alternative way to authenticate.

This commit fixes a bug where resuming a session would reset the VFS because the agent loop started from cycle 0 instead of the saved cycle count. It also refactors the Session service to reuse logic and adds a regression test.

Better inputs, themes support, global keymap, diff view for changes

This fixes an issue where the DiffReviewModal would appear empty. The root cause was the DiffView component having flexGrow: 1 inside a scrollbox, which caused layout issues. We also ensured the scrollbox is focused to allow scrolling.

Baz00k force-pushed the feat/improved-agent branch from 8f0293b to 7645efc Compare January 16, 2026 02:09

Baz00k requested a review from Copilot January 16, 2026 16:37

Copilot started reviewing on behalf of Baz00k January 16, 2026 16:37 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Baz00k added 26 commits January 17, 2026 12:24

feat: agent rework

3823fd6

chore: remove writer agent remnants

fe12b17

fix: add missing tools

d35bf9f

fix: add explicit overwrite flag

6f16f0c

fix: improve agents prompts for new wokflow

aeeaeab

refactor: yield error directly

b6e3dba

chore: improve write file tools descriptions

b48c34e

feat: preserve writer context across revisions to avoid re-reading files

6cfabe7

feat: sidebar with current status

ed40986

feat: improved visual and reliability of user feedback widget

d71d2ec

feat: improve UI

96b69a3

refactor: use global agent state for hook

6aff64c

feat: manual session restart on error

9ddaf98

fix: reject binary content and truncate long responses from web fetch

af708f3

feat: add support for reading PDF files

a28b7b9

fix: launch tui correctly with root level command if arguments provided

c1edb2f

fix: include current date in writer and reviewer prompts

12ca9f1

fix: ensure vfs state is preserved when resuming session

ca8c435

This commit fixes a bug where resuming a session would reset the VFS because the agent loop started from cycle 0 instead of the saved cycle count. It also refactors the Session service to reuse logic and adds a regression test.

chore: add more tests to prompts service

25e44ad

chore: add tui keymap

ac993be

feat: add diff view to user feedback

aa9e70b

fix: agent unable to write new files

d3d502b

fix: diff view not displaying properly

f3186f0

chore: clean up write command after move to VFS

08ae816

fix: improve context passed between agents and workflow description

7fc728c

chore(deps): update deps

ee85556

Baz00k added 14 commits January 17, 2026 12:24

fix: ai generating empty response is now a valid case

41efd99

refactor: use effect fn for readability

115cee0

feat: UI total revamp

b258fcd

Better inputs, themes support, global keymap, diff view for changes

fix: remove theme from header

9be18e5

feat: improve task input experience

d77dbed

fix: input overflow and sizing issues

7bf1cd4

chore: improve color palettes

bc5d7b7

fix: input label

0612253

feat: unified user feedback modal

50e8db4

refactor: use effect fn

ad670d8

style: autoformat

a4fa692

refactor: address review comment about hook architecture

62b7458

chore: add test

7c21a85

Baz00k force-pushed the feat/improved-agent branch from 1f44609 to 7c21a85 Compare January 17, 2026 11:24

Baz00k marked this pull request as ready for review January 17, 2026 12:01

Baz00k merged commit 53f6ce5 into master Jan 17, 2026
1 check passed

Baz00k deleted the feat/improved-agent branch January 17, 2026 12:02

github-actions bot mentioned this pull request Jan 17, 2026

chore(master): release 0.7.0 #30

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat/improved agent #31

Feat/improved agent #31

Uh oh!

Baz00k commented Jan 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Feat/improved agent #31

Feat/improved agent #31

Uh oh!

Conversation

Baz00k commented Jan 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants