Dr-t-Remediations

[Brean0]

Contains the remediations in #1047 , in addition to:

Not Reported fixes and additions

---

• Changing the function signature and logic of pipelineConvertto use pipeCalls instead of advancedFarmCalls.
• Update the calculation of bdv in LibTokenSilo to properly round up.
• Update the totalGerminatingBalanceChanged to properly emit the correct season when increasing germination.
• Update the bdvs function to properly return the bdv values.
• Adds Constants + Whitelist Update #1054, which:
  • updates the gaugePoint and LiquidityWeight function to use arbitrary data set in the GaugePoint and LiquidityWeight Implementation.
  • consolidates the various whitelist functions into a single whitelist function in favor of simplicity.
  • updates DepotFacet to use C.PIPELINE.
  • Updates the gaugePoint, LiquidityWeight, and Oracle Implementation Verification function to properly revert.
• Adjust Bean seeds on rain start by modifying beanToMaxLpGpPerBdvRatio to the minimum value. Adjust seeds upon rain start #1057
• Addresses the BeanstalkPrice contract failing along with whitelist data errors and additional data parsing in the reseed. Fix: Reseed Whitelist #1067
• Adds data for external unripe holders Add External Unripe Data in Reseed #1073

Reported Issues

---

High/Medium

• [H-01] LibUsdOracle.sol.getUsdPrice() returns price with incorrect precision when uses Uniswap pool Fix uniswap oracle precision, mainnet testing using vm.createSelectFork from block number in forge tests #1060
• [H-02] ReseedBarn.mintFertilizers() will corrupt Fertilizer queue state Reseed Fert Fix #1074
• [M-05] (M26 from codehwaks) Only increase a receivers internal balance in L1ReceiverFacet instead of double incrementing global values. Fix: Set only individual receiver internal balance in L1RecieverFacet. #1077
• [M-06] Fix: Mint bean sided liquidity to the L2 BCM #1061
• [M-07] calculateTokenBeanPriceFromReserves incorrect conditional. Fix: calculateTokenBeanPriceFromReserves incorrect conditional. #1072
• [M-04] Update STALK_BDV_PRECISION to new decimals. Fix: Update STALK_BDV_PRECISION to new decimals.  #1071
• [M-03] Set excessFeeRefundAddress to L2 receiver rather than L1 msg.sender Fix: Set excessFeeRefundAddress to L2 receiver rather than L1 msg.sender #1069
• [M-02] Fix: Incorrect Plot issuance in case activeField is updated before user's migration #1064

---

Low

• [L-02] Remove unused variables Remove unused storage vars #1065
• [L-03] Fix: Temperature if ladder incorrect value for delta=1 #1062
• [L-05] (L10 from codehwaks) Decimal fix for getWellTwaUsdLiquidityFromReserves when tokenUsd = 1 getWellTwaUsdLiquidityFromReserves decimal fix.  #1075

---

Notes

• [L-01] (DOS on withdrawal of germinating deposit migrated via L1ReceiverFacet.sol) and
• [M-01] (After migration Stalk is minted twice for germinating deposits migrated via L1RecieverFacet.sol) will be addressed by disallowing deposits/transfers/etc 2 hours before the migration.