Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contract functions, pt. 2 #518

Merged
merged 8 commits into from
Jun 28, 2023
Merged

Fix contract functions, pt. 2 #518

merged 8 commits into from
Jun 28, 2023

Conversation

silochad
Copy link
Contributor

@silochad silochad commented Jun 28, 2023 •
edited
Loading

UI & SDK builds now passing (though underlying naming & some logic needs reworking according to Silo V3 spec).

  • Refactor EventProcessor to support new events, update EventManager
  • Switch Silo & Field updaters in the UI to fetching & processing events via the SDK's event processor, remove the UI one
  • First-pass simplification of the EventProcessor, followup PRs will reduce things (especially types) down further, for ex. there are few types for Deposit crates
  • Get rid of duplicate UI code related to event processing
  • Add helper for migrating from BNJS <> ethers BN <> TokenValue

@silochad silochad mentioned this pull request Jun 28, 2023
Merged
@silochad
Copy link
Contributor Author

Requesting retroactive review

@silochad silochad merged commit 42067eb into silo-v3-ui Jun 28, 2023
0 of 2 checks passed
@silochad silochad deleted the fix-contract-functions branch June 28, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@silochad