Event processor: Field #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
silochad
commented
Jun 28, 2023
| @@ -83,6 +76,8 @@ export class EventProcessor { | |||
|
|
|||
| // Field | |||
| this.plots = initialState?.plots || new Map(); | |||
|
|
|||
| return this; | |||
There was a problem hiding this comment.
reverting this change in a followup pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce the Field event processor; migrate from the previous BigNumberJS & object approach to ethers.BigNumber and Maps.
Reintroduce helper function parsePlots to split plots into harvestable & non-harvestable. Add test for this.
Use the processor in the farmer/field/updater and wrangle the ethers.BigNumbers into BigNumberJS which is what the UI components expect currently. Not pretty but functional. Tested manually on some of my accounts.
yarn run jest processor.test