Crate refactors #524
Merged
Crate refactors #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silochad
force-pushed
the
crate-refactors
branch
from
8ce8ecd
to
fe642ce
Compare
|
Requesting retroactive review |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI has a lot of duplicate code that's also in the SDK. I migrated the farmer/silo updater to use the SDK (and thus stems), but that's created a lot of downstream issues. This PR fixes those & attempts to migrate some of the main forms to the SDK. I'm removing a lot of legacy code which was ported to the SDK & TokenValue that still exists in the UI w/ BigNumbers.