UI: When converting, ignore small ratio diffs and prioritize Season #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for basin ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for beanstalk-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Brean0
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since LP deposits can have varying BDV, the best option for the Farmer during a convert is to increase the BDV of their existing lowest-BDV crates.
The UI currently selects crates to convert purely on the basis of this ratio. However, if the
bdv/amountratio is similar for two crates, it is optimal for the farmer to select the crate with the higher season pre-Silo V3 to minimize potential stalk loss, since older crates can't be converted into seasons less than 1.This PR upgrades the selection function to prioritize
amount/bdvratio up to 4 decimal places. If two crates have the same ratio to 4 decimal places, the selection process sorts more recent deposits first.