Skip to content

feat(golang): add beta support #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

cfabianski
Copy link
Collaborator

Description

Add Beta support for Golang

Related

#1302

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@cfabianski cfabianski changed the title Feat/add golang beta support feat(golang): add beta support Oct 10, 2023
@cfabianski cfabianski force-pushed the feat/add-golang-beta-support branch from 1d8f76d to 7f99f61 Compare October 10, 2023 08:11
@cfabianski cfabianski requested a review from didroe October 11, 2023 12:48
Copy link
Contributor

@didroe didroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the language template. I like the idea, but I worry it will be hard to keep it up-to-date - my thinking is that something not used by the product will likely slowly diverge from the real languages, even with the best effort to apply changes to it

@cfabianski
Copy link
Collaborator Author

I'm not sure about the language template. I like the idea, but I worry it will be hard to keep it up-to-date - my thinking is that something not used by the product will likely slowly diverge from the real languages, even with the best effort to apply changes to it

Will delete the template after I'm done with Python. I agree.

@cfabianski cfabianski force-pushed the feat/add-golang-beta-support branch from 7f99f61 to 412d476 Compare October 11, 2023 13:01
@cfabianski cfabianski merged commit 418030e into main Oct 11, 2023
@cfabianski cfabianski deleted the feat/add-golang-beta-support branch October 11, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants