Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3665: add multi-dim support to arkouda.testing module #3751

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Closes #3665: add multi-dim support to arkouda.testing module #3751

merged 1 commit into from
Sep 18, 2024

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Sep 6, 2024

Multi-dim seems to be working, resulting from the other recent PRs. This ticket verifies it's working by adding some multi-dim unit tests.

Closes #3665: add multi-dim support to arkouda.testing module

@ajpotts ajpotts force-pushed the 3665-add-multi-dim-support-to-arkouda.testing-module branch 2 times, most recently from 1606baa to 59467cf Compare September 6, 2024 16:22
@ajpotts ajpotts marked this pull request as ready for review September 6, 2024 16:22
stress-tess
stress-tess reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments on the first of the tests, but it seems to apply to the others as well

tests/testing/asserters_test.py Outdated Show resolved Hide resolved
tests/testing/asserters_test.py Outdated Show resolved Hide resolved
@ajpotts ajpotts force-pushed the 3665-add-multi-dim-support-to-arkouda.testing-module branch 3 times, most recently from 3cc1e3b to 8837809 Compare September 18, 2024 15:01
jaketrookman
jaketrookman approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

stress-tess
stress-tess reviewed Sep 18, 2024
View reviewed changes
tests/testing/asserters_test.py Outdated Show resolved Hide resolved
tests/testing/asserters_test.py Outdated Show resolved Hide resolved
@ajpotts ajpotts force-pushed the 3665-add-multi-dim-support-to-arkouda.testing-module branch 2 times, most recently from 5c88fbb to 94ec552 Compare September 18, 2024 21:37
@ajpotts ajpotts force-pushed the 3665-add-multi-dim-support-to-arkouda.testing-module branch from 6075d90 to 3be21e8 Compare September 18, 2024 21:40
stress-tess
stress-tess approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@stress-tess stress-tess added this pull request to the merge queue Sep 18, 2024
Merged via the queue into Bears-R-Us:master with commit 1d241aa Sep 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stress-tess stress-tess stress-tess approved these changes

@jaketrookman jaketrookman jaketrookman approved these changes

@drculhane drculhane Awaiting requested review from drculhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add multi-dim support to arkouda.testing module
3 participants
@ajpotts @stress-tess @jaketrookman