Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3722: Remove @arkouda.registerND from SortMsg.chpl #3780

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Closes #3722: Remove @arkouda.registerND from SortMsg.chpl #3780

merged 3 commits into from
Sep 24, 2024

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Sep 19, 2024

Closes #3722: Remove @arkouda.registerND from SortMsg.chpl

@ajpotts ajpotts force-pushed the 3722-Remove-@arkouda.registerND-from-SortMsg.chpl branch from 9e7915e to 2f58564 Compare September 19, 2024 16:29
@ajpotts ajpotts marked this pull request as ready for review September 19, 2024 16:33
jeremiah-corrado
jeremiah-corrado reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Couple of things that could be simplified:

src/SortMsg.chpl Outdated Show resolved Hide resolved
src/SortMsg.chpl Outdated Show resolved Hide resolved
@ajpotts ajpotts force-pushed the 3722-Remove-@arkouda.registerND-from-SortMsg.chpl branch from b57710e to 8471af1 Compare September 19, 2024 19:22
@ajpotts ajpotts force-pushed the 3722-Remove-@arkouda.registerND-from-SortMsg.chpl branch from 8471af1 to 07fe429 Compare September 20, 2024 16:25
stress-tess
stress-tess reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just my own lack of understand but I thought we had to return message tuples

src/SortMsg.chpl Show resolved Hide resolved
stress-tess
stress-tess approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks amanda!

@stress-tess stress-tess added this pull request to the merge queue Sep 24, 2024
Merged via the queue into Bears-R-Us:master with commit 989c2f7 Sep 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiah-corrado jeremiah-corrado jeremiah-corrado left review comments

@stress-tess stress-tess stress-tess approved these changes

@jaketrookman jaketrookman Awaiting requested review from jaketrookman

@drculhane drculhane Awaiting requested review from drculhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove @arkouda.registerND from SortMsg.chpl.
3 participants
@ajpotts @stress-tess @jeremiah-corrado