Sony lens identification improvement #7281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let Exiv2 get the lens name if the lens spec is present. Otherwise, use the lens ID.
Lawrence37
force-pushed
the
sony-lens-identification
branch
from
69b1b57 to
79d402c
Compare
|
Fixed the compilation error when using clang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the metadata for various ARWs, I noticed the lens information in the metadata is correct as long as the LensSpec is not unknown. This improves the lens identification by checking the LensSpec. If it is unknown, take the lens name from the LensID. Otherwise, let Exiv2 handle the lens name.
Unknown LensSpec example: https://discuss.pixls.us/t/call-for-testing-rawtherapee-metadata-handling-with-exiv2-includes-cr3-support/36240/36
Known LensSpec example: #7278 (comment)
Closes #7278.