Fix direct mentions #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mentions were ignored previously, because the bot ID was never set on any of the routes. This sets the ID when the bot is run.
|
@chris-skud Any hope of this being merged? Easy enough to patch on our end but this is such a simple fix I'm surprised it's not been merged. |
|
@EmmaSimon does this still work? I've been trying your fork with the simple.go example, but no luck. Maybe I'm doing something wrong. |
|
@lucymhdavies The PR worked for me on head. At this point though someone should probably fork this project and maintain it separately, it's pretty obvious @BeepBoopHQ isn't super interested in maintaining it anymore. |
|
Ah, my bad. I was still importing the BeepBoopHQ version. We're going to be using it a lot in our company soon, so our fork is: |
|
Can we please merge this? :) |
flw-cn
pushed a commit
to flw-cn/go-slackbot
that referenced
this pull request
Jun 25, 2018
Fix replies in existing threads
liamsorsby
pushed a commit
to liamsorsby/go-slackbot
that referenced
this pull request
Jul 7, 2022
…f_nlopes fixed reference to rtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentions were ignored previously, because the bot ID was never set on
any of the routes. This sets the ID when the bot is run.