refactor/ui_common_project #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced comprehensive unit tests for ProjectMateUi, ProjectTasksUi, ViewProjectsUi, and ProjectStateSelectedUi to validate behavior. Renamed `getTasksForProject` to `getProjectTasks` in related use cases and updated corresponding references across affected classes for consistency.
introduced new test cases to validate task-related operations for various UIs, including state-based task grouping, null input handling, and redirection logic. enhanced coverage to ensure accurate display of tasks or appropriate messages when no tasks are present.
|
This test ensures that the UI for project tasks correctly handles cases where there are no tasks to display. It verifies that only headers and options are printed and no task details are shown, improving test coverage and reliability.
|
| every { reader.readInt() } returns 1 andThen 4 // First select view states, then exit | ||
|
|
||
| // Act | ||
| projectMateUi.show() |
made minor adjustments to variable naming and added necessary imports to improve code clarity and maintainability.
|
Mostafa-khaled21
previously approved these changes
May 13, 2025
YaseenOmar
previously approved these changes
May 13, 2025
ismailElkalili
previously approved these changes
May 13, 2025
BassantM
dismissed stale reviews from YaseenOmar, ismailElkalili, and Mostafa-khaled21
via
5782748
|
Mostafa-khaled21
previously approved these changes
May 13, 2025
YaseenOmar
previously approved these changes
May 13, 2025
BassantM
dismissed stale reviews from YaseenOmar and Mostafa-khaled21
via
afd186e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.