include label in get all task end point #126
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
| @@ -1,4 +1,6 @@ | |||
| namespace BlotzTask.Models | |||
| using BlotzTask.Data.Entities; | |||
There was a problem hiding this comment.
we should not Using entities in models
The idea is to encap all entity related only at data layer. (loose couple to improve the maintainability, in future if the app grow larger, our database related things only have dependent at data layer and does not blend across whole application)
| @@ -9,5 +11,6 @@ public class TaskItemDTO | |||
| public bool IsDone { get; set; } | |||
| public DateTime CreatedAt { get; set; } | |||
| public DateTime UpdatedAt { get; set; } | |||
| public Label Label { get; set; } | |||
There was a problem hiding this comment.
instead of using label entity, i will create a new DTO class for label
| public Label Label { get; set; } | |
| public Label Label { get; set; } | |
| public LabelDTO Label { get; set; } | |
| .Select(x => new TaskItemDTO | ||
| { | ||
| Id = x.Id, | ||
| Title = x.Title | ||
| Title = x.Title, | ||
| Label = x.Label |
There was a problem hiding this comment.
over here you will need to map to new dto once you create dto class
Benefit, now you only return necessary data you need to the endpoint, e.g. you dont need label id you just dont need to have it in dto (encapsulation)
Modify get all task endpoint to include label