# Add auto validation config & give a validation sample controller #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
LGTM, i can see you have a example controller and DTO, can i know why having the sample? rather having sample can we apply validation in the current API? If there is no post endpoint then make sense to leave the sample controller |
|
I explained it ON pr review channel.
Aug-8 ***@***.***>于2024年9月13日 周五10:24写道：
… LGTM, i can see you have a example controller and DTO, can i know why
having the sample? rather having sample can we apply validation in the
current API?
If there is no post endpoint then make sense to leave the sample controller
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMWRALFIFWSFPNCAQJOBSCDZWJEGTAVCNFSM6AAAAABODFJWZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBXHEYTMMZVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
To refactor task controller contains a lot of work, I just want to make it
simple and give its owner to do it, which may help him know more about our
layered architecture and doing validation
Aug-8 ***@***.***> 于2024年9月13日周五 10:24写道：
… LGTM, i can see you have a example controller and DTO, can i know why
having the sample? rather having sample can we apply validation in the
current API?
If there is no post endpoint then make sense to leave the sample controller
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMWRALFIFWSFPNCAQJOBSCDZWJEGTAVCNFSM6AAAAABODFJWZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBXHEYTMMZVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
sol-wizard
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.