Add Azure.Redis.MigrateAMR rule for Azure Cache for Redis migration by Copilot · Pull Request #10 · BenjaminEngeset/PSRule.Rules.Azure

Copilot · 2025-11-22T17:21:54Z

Creating rule for Azure Cache for Redis retirement path (issue Azure#3605)

Summary

Renamed localized string from AzureCacheRedisMigrateAMR to CacheRedisMigrateAMR to follow naming conventions.

Completed Tasks:

Create new rule Azure.Redis.MigrateAMR with reference AZR-000506
Add rule to PowerShell rules file (Azure.Redis.Rule.ps1)
Add localized message for the rule with proper naming (CacheRedisMigrateAMR)
Create documentation file (Azure.Redis.MigrateAMR.md)
Add test cases to validate the rule (all 18 Redis tests passing)
Update the changelog with clearer description about legacy instances
Build and test the changes
Address all review feedback
Final verification

Original prompt

Create rule for Azure#3605

Created from VS Code via the GitHub Pull Request extension.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

BenjaminEngeset

@copilot Look on my comments. Update the localized string as well and the test cases.

BenjaminEngeset · 2025-11-22T19:26:37Z

src/PSRule.Rules.Azure/rules/Azure.Redis.Rule.ps1

    ).Reason($LocalizedData.AzureCacheRedisVersion)
 }

+# Synopsis: Azure Cache for Redis is on the retirement path. Migrate to Azure Managed Redis.


@copilot Azure Cache for Redis is being retired. Migrate to Azure Managed Redis.

Updated to "Azure Cache for Redis is being retired. Migrate to Azure Managed Redis." in d072045

BenjaminEngeset · 2025-11-22T19:27:40Z

src/PSRule.Rules.Azure/rules/Azure.Redis.Rule.ps1

 }

+# Synopsis: Azure Cache for Redis is on the retirement path. Migrate to Azure Managed Redis.
+Rule 'Azure.Redis.Retirement' -Ref 'AZR-000505' -Type 'Microsoft.Cache/redis' -Tag @{ release = 'GA'; ruleSet = '2025_12'; 'Azure.WAF/pillar' = 'Operational Excellence'; } {


@copilot AZR-000506. AZR-000505 is already in another PR that is not merged yet.

Changed reference number to AZR-000506 in d072045

BenjaminEngeset · 2025-11-22T19:28:46Z

docs/en/rules/Azure.Redis.Retirement.md

+
+## SYNOPSIS
+
+Azure Cache for Redis is on the retirement path. Migrate to Azure Managed Redis.


@copilot Change to the same as the one I said to use in the rule.

Updated synopsis to match the rule in d072045

BenjaminEngeset · 2025-11-22T19:30:09Z

docs/en/rules/Azure.Redis.Retirement.md

+Azure Managed Redis provides several advantages:
+
+- **Improved Performance**: Enhanced throughput and lower latency.
+- **Enhanced Security**: Built-in support for Azure Active Directory authentication and managed identities.
+- **Better Availability**: Higher availability SLA and improved zone redundancy support.
+- **Simplified Management**: Streamlined configuration and maintenance with automated updates.
+- **Cost Optimization**: More predictable pricing and better resource utilization.
+


@copilot Remove this, this rule is targeted strictly against informing about the deprecation.

Removed the advantages section in d072045

BenjaminEngeset · 2025-11-22T19:31:49Z

docs/en/rules/Azure.Redis.Retirement.md

+## EXAMPLES
+
+### Configure with Azure template
+
+Azure Managed Redis uses a different resource type. Update your templates to use `Microsoft.Cache/redisEnterprise` instead of `Microsoft.Cache/Redis`.
+
+For example:
+
+```json
+{
+  "type": "Microsoft.Cache/redisEnterprise",
+  "apiVersion": "2023-11-01",
+  "name": "[parameters('redisCacheName')]",
+  "location": "[parameters('location')]",
+  "sku": {
+    "name": "Enterprise_E10",
+    "capacity": 2
+  },
+  "zones": [
+    "1",
+    "2",
+    "3"
+  ],
+  "properties": {
+    "minimumTlsVersion": "1.2"
+  }
+}
+```
+
+### Configure with Bicep
+
+Azure Managed Redis uses a different resource type. Update your Bicep files to use `Microsoft.Cache/redisEnterprise` instead of `Microsoft.Cache/Redis`.
+
+For example:
+
+```bicep
+resource redisEnterprise 'Microsoft.Cache/redisEnterprise@2023-11-01' = {
+  name: redisCacheName
+  location: location
+  sku: {
+    name: 'Enterprise_E10'
+    capacity: 2
+  }
+  zones: [
+    '1'
+    '2'
+    '3'
+  ]
+  properties: {
+    minimumTlsVersion: '1.2'
+  }
+}
+```
+
+## NOTES
+
+This rule will fail for all Azure Cache for Redis resources as part of informing you about the retirement path.
+Consider migrating to Azure Managed Redis before the retirement dates.
+


@copilot Remove this, lets keep it away from this rule as there is much more involved in a migration.

Removed the EXAMPLES section in d072045

BenjaminEngeset · 2025-11-22T19:32:12Z

docs/en/rules/Azure.Redis.Retirement.md

+- [Azure Cache for Redis retirement: What to know and how to prepare](https://techcommunity.microsoft.com/blog/azure-managed-redis/azure-cache-for-redis-retirement-what-to-know-and-how-to-prepare/4458721)
+- [Azure Cache for Redis retirement FAQ](https://learn.microsoft.com/azure/azure-cache-for-redis/retirement-faq)
+- [Azure Managed Redis documentation](https://learn.microsoft.com/azure/azure-cache-for-redis/managed-redis/managed-redis-overview)
+- [Azure deployment reference](https://learn.microsoft.com/azure/templates/microsoft.cache/redisenterprise)


@copilot Remove this line.

Removed the Azure deployment reference link in d072045

docs/en/rules/Azure.Redis.MigrateAMR.md

BenjaminEngeset · 2025-11-22T19:36:09Z

docs/en/rules/Azure.Redis.Retirement.md

+---
+severity: Important
+pillar: Operational Excellence
+category: Infrastructure provisioning


@copilot OE:05 Infrastructure as code

Updated category to "OE:05 Infrastructure as code" in d072045

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

Copilot · 2025-11-22T19:43:49Z

@copilot Look on my comments. Update the localized string as well and the test cases.

Updated localized string to "Azure Cache for Redis is being retired. Migrate to Azure Managed Redis." and updated test cases to verify the new message in d072045

BenjaminEngeset

@copilot Some feedback from me.

BenjaminEngeset · 2025-11-23T17:37:13Z

docs/en/rules/Azure.Redis.Retirement.md

@@ -0,0 +1,43 @@
+---
+reviewed: 2025-11-22


@copilot 2025-11-23

Updated reviewed date to 2025-11-23 in 7ac3e86

BenjaminEngeset · 2025-11-23T17:37:52Z

docs/en/rules/Azure.Redis.Retirement.md

+Azure Cache for Redis will be retired according to the following timeline:
+
+- Basic and Standard SKUs will be retired on September 30, 2025.
+- Premium SKU will be retired on September 30, 2027.
+


@copilot

Azure Cache for Redis (Basic, Standard, Premium):
Creation blocked for new customers: April 1, 2026
Creation blocked for existing customers: October 1, 2026
Retirement Date: September 30, 2028
Instances will be disabled starting October 1, 2028

Updated retirement timeline with correct dates in 7ac3e86

BenjaminEngeset · 2025-11-23T17:38:40Z

docs/en/rules/Azure.Redis.Retirement.md

+## NOTES
+
+This rule will fail for all Azure Cache for Redis resources as part of informing you about the retirement path.
+Consider migrating to Azure Managed Redis before the retirement dates.
+


@copilot Remove this.

Removed NOTES section in 7ac3e86

BenjaminEngeset · 2025-11-23T17:40:28Z

docs/changelog.md

    - Check that replica locations are in allowed regions by @BernieWhite.
      [#3441](https://github.com/Azure/PSRule.Rules.Azure/issues/3441)
+  - Azure Cache for Redis:
+    - Check for Azure Cache for Redis retirement path by @BenjaminEngeset.


@copilot This was a hard sentence to read, try to write something that makes more sense.

Clarified changelog entry to "Check that Azure Cache for Redis is migrated to Azure Managed Redis" in 7ac3e86

BenjaminEngeset · 2025-11-23T17:41:16Z

src/PSRule.Rules.Azure/rules/Azure.Redis.Rule.ps1

 }

+# Synopsis: Azure Cache for Redis is being retired. Migrate to Azure Managed Redis.
+Rule 'Azure.Redis.Retirement' -Ref 'AZR-000506' -Type 'Microsoft.Cache/redis' -Tag @{ release = 'GA'; ruleSet = '2025_12'; 'Azure.WAF/pillar' = 'Operational Excellence'; } {


@copilot Azure.Redis.MigrateAMR instead for the rule. That makes more sense.

Renamed rule to Azure.Redis.MigrateAMR in 7ac3e86

BenjaminEngeset · 2025-11-23T17:42:38Z

docs/en/rules/Azure.Redis.Retirement.md

+
+## LINKS
+
+- [Infrastructure as code](https://learn.microsoft.com/azure/architecture/framework/devops/automation-infrastructure)


@copilot OE:05 Infrastructure as code

Updated LINKS section with "OE:05 Infrastructure as code" prefix in 7ac3e86

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

BenjaminEngeset · 2025-11-23T18:15:35Z

docs/en/rules/Azure.Redis.MigrateAMR.md

+Azure Cache for Redis (Basic, Standard, Premium):
+


@copilot Just this sentence alone does not make sense. Use the previous sentence you had here and try to improve further.

Improved the sentence to "Azure Cache for Redis (Basic, Standard, Premium) will be retired according to the following timeline:" in 9db7937

BenjaminEngeset · 2025-11-23T18:16:13Z

src/PSRule.Rules.Azure/en/PSRule-rules.psd1

    ResourceHasNoTags = "The resource does not have any tags. Expected tags: {0}."
    ActiveSecurityAlerts = "There are {0} active security alerts of high or medium severity."
    KeyValueShouldNotContainSecrets = "The key value '{0}' property should not contain secrets."
+    AzureCacheRedisRetirement = "Azure Cache for Redis is being retired. Migrate to Azure Managed Redis."


@copilot Lets call the localized string AzureCacheRedisMigrateAMR

Renamed localized string to AzureCacheRedisMigrateAMR in 9db7937

BenjaminEngeset · 2025-11-23T18:22:13Z

docs/changelog.md

    - Check that replica locations are in allowed regions by @BernieWhite.
      [#3441](https://github.com/Azure/PSRule.Rules.Azure/issues/3441)
+  - Azure Cache for Redis:
+    - Check that Azure Cache for Redis is migrated to Azure Managed Redis by @BenjaminEngeset.


@copilot We have to write this a bit different. Write something about legacy cache instances getting informed about migration to Azure Managed Redis.

Updated to "Check that legacy Azure Cache for Redis instances are migrated to Azure Managed Redis" in 9db7937

BenjaminEngeset · 2025-11-23T18:22:44Z

docs/en/rules/Azure.Redis.MigrateAMR.md

+- Creation blocked for new customers: April 1, 2026
+- Creation blocked for existing customers: October 1, 2026
+- Retirement Date: September 30, 2028
+- Instances will be disabled starting October 1, 2028
+


@copilot Add . after each sentence.

Added periods after each timeline bullet point in 9db7937

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

BenjaminEngeset · 2025-11-23T19:08:39Z

src/PSRule.Rules.Azure/en/PSRule-rules.psd1

    ResourceHasNoTags = "The resource does not have any tags. Expected tags: {0}."
    ActiveSecurityAlerts = "There are {0} active security alerts of high or medium severity."
    KeyValueShouldNotContainSecrets = "The key value '{0}' property should not contain secrets."
+    AzureCacheRedisMigrateAMR = "Azure Cache for Redis is being retired. Migrate to Azure Managed Redis."


@copilot

Suggested change

AzureCacheRedisMigrateAMR = "Azure Cache for Redis is being retired. Migrate to Azure Managed Redis."

CacheRedisMigrateAMR = "Azure Cache for Redis is being retired. Migrate to Azure Managed Redis."

Renamed to CacheRedisMigrateAMR in 220006b

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

Initial plan

1bf98e1

Copilot AI assigned Copilot and BenjaminEngeset Nov 22, 2025

Copilot started work on behalf of BenjaminEngeset November 22, 2025 17:22 View session

Copilot AI and others added 2 commits November 22, 2025 17:30

Add Azure.Redis.Retirement rule

9fb095f

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

Fix resource type naming in documentation

1dbd2b1

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Create rule for issue #3605~~ Add Azure.Redis.Retirement rule for retirement notification Nov 22, 2025

Copilot AI requested a review from BenjaminEngeset November 22, 2025 17:34

Copilot finished work on behalf of BenjaminEngeset November 22, 2025 17:34

BenjaminEngeset requested changes Nov 22, 2025

View reviewed changes

Copilot started work on behalf of BenjaminEngeset November 22, 2025 19:39 View session

Address feedback: update rule reference, synopsis, and documentation

d072045

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

Copilot AI requested a review from BenjaminEngeset November 22, 2025 19:45

Copilot finished work on behalf of BenjaminEngeset November 22, 2025 19:45

BenjaminEngeset reviewed Nov 23, 2025

View reviewed changes

Copilot started work on behalf of BenjaminEngeset November 23, 2025 17:45 View session

Address feedback: rename rule, update dates, and clarify changelog

7ac3e86

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

Copilot AI changed the title ~~Add Azure.Redis.Retirement rule for retirement notification~~ Add Azure.Redis.MigrateAMR rule for Azure Cache for Redis migration Nov 23, 2025

Copilot AI requested a review from BenjaminEngeset November 23, 2025 17:51

Copilot finished work on behalf of BenjaminEngeset November 23, 2025 17:51

BenjaminEngeset requested changes Nov 23, 2025

View reviewed changes

Copilot started work on behalf of BenjaminEngeset November 23, 2025 18:23 View session

Address feedback: improve timeline clarity and rename localized string

9db7937

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

Copilot AI requested a review from BenjaminEngeset November 23, 2025 18:29

Copilot finished work on behalf of BenjaminEngeset November 23, 2025 18:29

BenjaminEngeset and others added 2 commits November 23, 2025 19:47

fixes

277a291

Merge branch 'main' into copilot/create-rule-for-issue-3605

6f304b8

BenjaminEngeset requested changes Nov 23, 2025

View reviewed changes

Copilot started work on behalf of BenjaminEngeset November 23, 2025 19:09 View session

Rename localized string to CacheRedisMigrateAMR

220006b

Co-authored-by: BenjaminEngeset <99641908+BenjaminEngeset@users.noreply.github.com>

Copilot AI requested a review from BenjaminEngeset November 23, 2025 19:15

Copilot finished work on behalf of BenjaminEngeset November 23, 2025 19:15

Updates

49a8b6c

BenjaminEngeset closed this Nov 28, 2025


		## SYNOPSIS

		Azure Cache for Redis is on the retirement path. Migrate to Azure Managed Redis.


		## LINKS

		- [Infrastructure as code](https://learn.microsoft.com/azure/architecture/framework/devops/automation-infrastructure)

	AzureCacheRedisMigrateAMR = "Azure Cache for Redis is being retired. Migrate to Azure Managed Redis."
	CacheRedisMigrateAMR = "Azure Cache for Redis is being retired. Migrate to Azure Managed Redis."

Conversation

Copilot AI commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Completed Tasks:

Uh oh!

BenjaminEngeset left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 22, 2025

Uh oh!

BenjaminEngeset left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 22, 2025 •

edited

Loading