Duplex #178
Open
Duplex #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… performed in one session
|
I'm not comfortable with a PR that does two things. I think it would be best to split in update deps and support duplex. But I don't have time to handle this anymore unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a patch so that AndroidCupsPrint will pass Job infos/attributes on to Cups4J and beyond, and handle duplex modes.
I more or less had to upgrade everything, particularly the version of Gradle which was deemed obsolete by my AndroidStudio. I let that and imports optimization in separate commits so you don't have to keep it if you know better.
Please forgive my clumsiness, I'm no Android developer.