[EXP][CMDBUF] Support for Node Profiling #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also document limitations of this implementation in CONTRIB.rst
… cmdbuf-node-profiling
|
Linked DPC++ PR : reble/llvm#353 |
EwanC
reviewed
Jan 26, 2024
| - type: size_t* | ||
| name: pPropSizeRet | ||
| desc: "[out][optional] pointer to the actual size in bytes returned in propValue" | ||
| returns: |
There was a problem hiding this comment.
Could have an error $X_RESULT_ERROR_INVALID_COMMAND_BUFFER_SYNC_POINT_EXP if syncPoint doesn't correspond to a graph node in event.
There was a problem hiding this comment.
This error has been added.
There was a problem hiding this comment.
thanks, could have a sub-bullet point describing when this error is returned
EwanC
approved these changes
Jan 30, 2024
| // Get SyncPoint profiling information | ||
| ${x}_event_handle_t event; | ||
|
|
||
| ${x}CommandBufferEnqueueExp(hCommandBuffer, hQueue, 0, nullptr, |
There was a problem hiding this comment.
Need to call ${x}CommandBufferFinalizeExp before this
| - type: size_t* | ||
| name: pPropSizeRet | ||
| desc: "[out][optional] pointer to the actual size in bytes returned in propValue" | ||
| returns: |
There was a problem hiding this comment.
thanks, could have a sub-bullet point describing when this error is returned
Bensuo
approved these changes
Jan 30, 2024
|
UR Upstream PR: oneapi-src#1309 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urEventGetSyncPointProfilingInfoExp. This function queries the profiling information of a sync-point. It takes the handle of the event returned from the graph submission and the sync-point associated with the node from which we want to obtain the profiling information.