Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat pointers as value types #159

Merged
merged 6 commits into from
Sep 14, 2024

Conversation

ds5678
Copy link
Collaborator

@ds5678 ds5678 commented Sep 8, 2024

Resolves #156

@ds5678 ds5678 added bug Something isn't working generation Related to assembly generation labels Sep 8, 2024
@ds5678 ds5678 added this to the 1.5.0 milestone Sep 8, 2024
@ds5678 ds5678 requested a review from js6pak September 8, 2024 21:46
@js6pak
Copy link
Member

js6pak commented Sep 10, 2024

Shouldn't we literally treat pointers as (blittable) value types and use the same code paths?

@ds5678
Copy link
Collaborator Author

ds5678 commented Sep 10, 2024

I'll fix it

@ds5678 ds5678 force-pushed the pointer-type-improvements branch from cf7bddd to d7d68fb Compare September 12, 2024 06:06
Handle generics for pointers too

formatting

Implement requested changes
@ds5678 ds5678 force-pushed the pointer-type-improvements branch from d7d68fb to e7164cf Compare September 13, 2024 22:30
@ds5678 ds5678 merged commit 5261733 into BepInEx:master Sep 14, 2024
2 checks passed
@ds5678 ds5678 deleted the pointer-type-improvements branch September 14, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working generation Related to assembly generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

void* Generation Issues
2 participants