Implement teams support #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonachea
requested changes
Aug 6, 2024
everythingfunctional
force-pushed
the
implement-teams
branch
4 times, most recently
from
c5021bf to
b074f86
Compare
bonachea
requested changes
Aug 8, 2024
everythingfunctional
force-pushed
the
implement-teams
branch
from
dae0768 to
e78b62a
Compare
|
I think this is the design/implementation we want now, but I'm not understanding something that is wrong with the linked list of coarrays on images other than 1 in a team. It's not treating pointers that have been set to null as being null, but only on images other than 1. |
bonachea
requested changes
Aug 9, 2024
There was a problem hiding this comment.
New test looks good, and we seem to be getting closer!
I didn't notice a defect likely to explain exactly the runtime crash you report. However I did notice and comment on a few important runtime checks that are currently missing and might potentially explain other runtime crashes.
Also added a few other misc minor requests.
|
I found and fixed the bug! Only image 1 was calculating where the new heap started :face_palm:. |
bonachea
approved these changes
Aug 9, 2024
We maintain that child teams can use the "remaining" memory from the current team's heap, which requires some addtional overhead during allocation and deallocation of coarrays.
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
everythingfunctional
force-pushed
the
implement-teams
branch
from
5aef8bf to
8a21765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements our basic strategy for supporting teams.