Unit test with Julienne #133

rouson · 2024-09-08T00:09:55Z

Because the Veggies unit testing framework exposes what appears to be an internal compiler error in LLVM Flang (flang-new), this PR refactors the Caffeine test suite to replace Veggies with Julienne, which provides similar functionality and supports Flang. This commit also removes the unused iso_varying_string dependency and renames all test/caf_* files to test/prif_*.

To Do

This fixes a previously non-conformant way of setting a character pointer length (a standard constraint prohibits passing an actual argument with a deferred length to c_f_pointer).

fix(co_reduce): rm unused variable Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

In order to support testing with the LLVM compilers, this commit begins the process of switching to the Julienne unit testing framework. This commit also removes the unsed iso_varying_string dependency and renames all test/caf_* files to test/prif_*. Status ------ 6 of 6 tests refactored to use Julienne pass with the LLVM compilers. Done ---- -[X] Updated dependencies in fpm.toml.template -[X] Replaced main test program -[X] Refactored/renamed prif_init test using julienne -[X] Refactored/renamed prif_allocate test using julienne To Do ----- -[ ] Refactor/rename caf_co_broadcast_test.f90 -[ ] Refactor/rename caf_co_max_test.f90 -[ ] Refactor/rename caf_co_min_test.f90 -[ ] Refactor/rename caf_co_reduce_test.f90 -[ ] Refactor/rename caf_co_sum_test.f90 -[ ] Refactor/rename caf_error_stop_test.f90 -[ ] Refactor/rename caf_image_index_test.f90 -[ ] Refactor/rename caf_num_images_test.f90 -[ ] Refactor/rename caf_rma_test.f90 -[ ] Refactor/rename caf_stop_test.f90 -[ ] Refactor/rename caf_teams_test.f90 -[ ] Refactor/rename caf_this_image_test.f90

This commit matches the test descriptions in the block of code that exists to support building with gfortran.

Although these tests fail with flang-new, they should pass with gfortran.

bonachea

I realize this is still Draft, but I provided a few suggestions on preprocessor style.

test/prif_init_test_m.F90

src/prif.f90

build(preprocess): use HAVE_SELECTED_LOGICAL_KIND Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

This reverts commit b09efc5.

This reverts commit c60ab05.

Based on compiler pre-defined macros, this commit defines the following macros in include/language-support.F90: - HAVE_SELECTED_LOGICAL_KIND - HAVE_PROCEDURE_ACTUAL_FOR_POINTER_DUMMY - HAVE_PROCEDURE_ACTUAL_FOR_POINTER_DUMMY and adds the line #include "language-support.F90" to src/prif.f90 and each file in the test/ subdirectory. This replaces the recently committed feature macros.

This commit removes the HAVE_MULTI_IMAGE_SUPPORT macro because we'll call PRIF/Caffeine procedures for all multi-image support inside Caffeine.

test/main.F90

everythingfunctional · 2024-09-10T20:47:14Z

test/main.F90

+#ifdef __flang__
+    print *
+    print *,"!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
+    print *
+    print *,"LLVM Flang detected. Skipping tests that crash:"
+    print *,"  - prif_co_max_test"
+    print *,"  - prif_co_min_test"
+    print *,"  - prif_co_reduce_test"
+    print *,"  - prif_co_sum_test"
+    print *,"  - prif_error_stop_test"
+    print *,"  - prif_image_index_test"
+    print *,"  - prif_stop_test"
+    print *
+    print *,"!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
+#else
+    call prif_co_max_test%report(passes, tests)
+    call prif_co_min_test%report(passes, tests)
+    call prif_co_reduce_test%report(passes, tests)
+    call prif_co_sum_test%report(passes, tests)
+    call prif_error_stop_test%report(passes, tests)
+    call prif_image_index_test%report(passes, tests)
+    call prif_rma_test%report(passes, tests)
+    call prif_stop_test%report(passes, tests)
+#endif


This evokes a somewhat philosophical question about how to proceed in the face of known failures.

@everythingfunctional that's a solid point. At this point, I'd like to understand and address the issues even if the only outcome is that Caffeine and/or Julienne improve whether or not we decide for Caffeine to use Julienne. So far, these issues have helped to identify problems in both packages that I'm working on addressing. Most of the above failures relate the handling of character stop codes in error termination (see issue #77). I'm making good progress with addressing the above failures and hope to have most or all fixed by the time of tomorrow's call.

Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

everythingfunctional · 2024-09-16T21:38:56Z

src/caffeine/unit_test_parameters_m.f90

This feels like it doesn't belong in the main library. I'd suggest instead making another fpm project in this repo, i.e. fpm new --lib caffeine-test-helpers, putting this in there, and then specifying that just the tests and those examples depend on it. I.e.

[dev-dependencies] caffeine-test-helpers = { path = "./caffeine-test-helpers" }

rouson and others added 10 commits September 6, 2024 13:52

fix(sync_all): call prif_sync_all

b11575d

fix(co_reduce): correctly set character ptr length

66e4b6d

This fixes a previously non-conformant way of setting a character pointer length (a standard constraint prohibits passing an actual argument with a deferred length to c_f_pointer).

fix(install.sh): if flang, add assumed-rank flags

8aeb5ea

Apply suggestions from code review

2f8f71e

fix(co_reduce): rm unused variable Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

test(collectives): work around flang bugs

0426d7a

build(fpm): switch to debug builds

d2791d2

refac(c_f_string): use non-concurrent do

886baa3

fix(prif_allocate_test): .f90->.F90 to preprocess

b5326dd

test(prif_init): fix test desc in gfortran code

7ab646e

This commit matches the test descriptions in the block of code that exists to support building with gfortran.

rouson force-pushed the switch-to-julienne branch from a567f3b to 7ab646e Compare September 8, 2024 00:39

rouson added 3 commits September 7, 2024 17:45

test(num_images): add refactored passing test

c3b2279

test(this_image): add refactored passing test

5faf190

test(prif_num_images_test): fix typo

0779145

rouson force-pushed the switch-to-julienne branch from 61c1d0c to 969a56a Compare September 8, 2024 01:10

test(prif_allocate): better test subject text

878f0d0

rouson force-pushed the switch-to-julienne branch from 969a56a to 878f0d0 Compare September 8, 2024 01:11

rouson added 12 commits September 7, 2024 18:31

WIP: add failing error stop test

0be5de7

WIP: add failing prif_stop test

094c780

WIP: disable stop/error-stop tests

c9cd812

test(co_broadcast): add passing test

dc922bd

test(prif_num_images): fix typo

e8f92ff

test(prif_co_broadcast): fix typo in gfortran code

d961d2e

test(main): run stop/error-stop tests

d95ab4a

Although these tests fail with flang-new, they should pass with gfortran.

feat(prif): leverage selected_logical_kind support

027ca56

test(teams): add passing test

cdf2590

WIP: add prif_image_index test - fails with flang

05fdb05

chore(prif_image_index): whitespace edits

1ce9151

WIP: add prif_co_min test - fails with flang

c560785

bonachea requested changes Sep 8, 2024

View reviewed changes

test/prif_init_test_m.F90 Outdated Show resolved Hide resolved

src/prif.f90 Outdated Show resolved Hide resolved

src/prif.f90 Outdated Show resolved Hide resolved

rouson and others added 17 commits September 8, 2024 12:04

WIP: add prif_com_ax test - fails with flang

a0c9812

Apply suggestions from code review

c60ab05

build(preprocess): use HAVE_SELECTED_LOGICAL_KIND Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

build(preprocess): define feature-macro values

b09efc5

Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

fix(prif): .f90 -> .F90 for preprocessing

fc31b13

Revert "build(preprocess): define feature-macro values"

abb3c55

This reverts commit b09efc5.

Revert "Apply suggestions from code review "

d8dc653

This reverts commit c60ab05.

chore(language-support): rm unused macro

83d73e4

This commit removes the HAVE_MULTI_IMAGE_SUPPORT macro because we'll call PRIF/Caffeine procedures for all multi-image support inside Caffeine.

chore(prif.F90): reversing mistaken rename

4239bc2

chore(prif): extension rename (retrying)

6689839

build(include): rm indents to support gfortran

e384e2e

build: fix preprocessor macros

0350e69

test(co_m{in,ax}): fix gfortran workaround blocks

519c707

WIP: add co_reduce test - fails with flang

e555dc8

WIP: add prif_co_sum test - fails with flang

36d6213

refac(test/main): reorganize declarations

6466fb5

WIP: add prif_rma test -- fails with flang

a746520

bonachea requested changes Sep 10, 2024

View reviewed changes

test/main.F90 Outdated Show resolved Hide resolved

everythingfunctional reviewed Sep 10, 2024

View reviewed changes

rouson and others added 3 commits September 10, 2024 14:16

fix(test/main): call caffeine for error termination

80796fd

Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>

fix(error_stop_test): add cmdstatus arg

0c74e9d

WIP: one prif_stop test now passes.

1a7f302

everythingfunctional reviewed Sep 16, 2024

View reviewed changes

rouson changed the title ~~Unit test with Julienne to support building with the LLVM compilers~~ Unit test with Julienne Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unit test with Julienne #133

Unit test with Julienne #133

rouson commented Sep 8, 2024 •

edited

Loading

bonachea left a comment

everythingfunctional Sep 10, 2024

rouson Sep 10, 2024

everythingfunctional Sep 16, 2024

Unit test with Julienne #133

Are you sure you want to change the base?

Unit test with Julienne #133

Conversation

rouson commented Sep 8, 2024 • edited Loading

To Do

bonachea left a comment

Choose a reason for hiding this comment

everythingfunctional Sep 10, 2024

Choose a reason for hiding this comment

rouson Sep 10, 2024

Choose a reason for hiding this comment

everythingfunctional Sep 16, 2024

Choose a reason for hiding this comment

rouson commented Sep 8, 2024 •

edited

Loading