Add more team support #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement prif_num_images_with_team - Implement prif_this_image_no_coarray(team) - Cache this_image/num_images in the Fortran-level team_data - Use that everywhere instead of caf_this_image/caf_num_images - Cosmetic fixes to caf_this_image/caf_num_images Fixes issue BerkeleyLab#59
|
@ktras please review this PR in the next few days. I now have a second Caffeine PR staged behind this one, I'm waiting for this one to be finalized and merged before posting it. |
ktras
reviewed
Jan 13, 2025
ktras
requested changes
Jan 13, 2025
|
@ktras thanks for your review, I believe I've addressed or responded to all of your concerns. Ready for next round of review. |
Add coverage for: * prif_get_team * prif_team_number * prif_num_images with team * prif_this_image with team Correct a defect in `result_` aggregation that was wiping out earlier test results. --- Apply suggestions from code review Co-authored-by: Katherine Rasmussen <krasmussen@lbl.gov>
This was causing undiagnosed non-fatal errors in CI of the form: ``` ./install.sh: 402: [[: not found ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
prif_team_numberprif_get_teamprif_num_images_with_teamprif_this_image_no_coarray(team)This notably completes implementation of the "Teams" chapter of PRIF 0.5, and makes significant progress towards completing "Image Queries".
This PR also fixes #59, thereby avoiding cross-language calls on every this_image and num_images query.