-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: v1.57.5 broke Windows compatibility on litellm cli proxy #7677
Comments
@EDM115 i'm sorry about that, we could have done a better job around this are you seeing this on the litellm proxy server or python SDK ? |
As a note this is only a optional dep - curious how did this impact you ? Line 36 in e98c1b8
|
i'll add a dependency test to ensure no unexpected deps get added to core sdk. Thanks for the ticket @EDM115 |
should be fixed here: 4c608a1 I've queued a new release |
To litellm users impacted by this: sorry for the issue, will update this thread on how we are improving our testing to avoid issues like this in the future StatusNew release with fix is queued up |
…are marked as extras on poetry Fixes #7677
Thanks for the quick fix @ishaan-jaff ! |
fixed here : https://pypi.org/project/litellm/1.57.7/ cc @axiomofjoy, @EDM115 |
We've also added a test here to ensure we don't add an optional dependency as required |
* test(test_basic_python_version.py): assert all optional dependencies are marked as extras on poetry Fixes #7677 * docs(secret.md): clarify 'read_and_write' secret manager usage on aws * docs(secret.md): fix doc * build(ui/teams.tsx): add edit/delete button for updating user / team membership on ui allows updating user role to admin on ui * build(ui/teams.tsx): display edit member component on ui, when edit button on member clicked * feat(team_endpoints.py): support updating team member role to admin via api endpoints allows team member to become admin post-add * build(ui/user_dashboard.tsx): if team admin - show all team keys Fixes #7650 * test(config.yml): add tomli to ci/cd * test: don't call python_basic_testing in local testing (covered by python 3.13 testing)
thanks for the fix guys :) |
* test(test_basic_python_version.py): assert all optional dependencies are marked as extras on poetry Fixes BerriAI#7677 * docs(secret.md): clarify 'read_and_write' secret manager usage on aws * docs(secret.md): fix doc * build(ui/teams.tsx): add edit/delete button for updating user / team membership on ui allows updating user role to admin on ui * build(ui/teams.tsx): display edit member component on ui, when edit button on member clicked * feat(team_endpoints.py): support updating team member role to admin via api endpoints allows team member to become admin post-add * build(ui/user_dashboard.tsx): if team admin - show all team keys Fixes BerriAI#7650 * test(config.yml): add tomli to ci/cd * test: don't call python_basic_testing in local testing (covered by python 3.13 testing)
What happened?
In v1.57.5
uvloop
has been introduced as a dependency oflitellm
(#7662).However,
uvloop
is not compatible with Windows (see MagicStack/uvloop#14).This should have been at the very least be noted as a Breaking change, as it is impacting other users (#7662 (comment)).
Is
uvloop
a definitive requirement moving forward ? If so, there should be a mention in the README about Windows incompatibility for >=v1.57.5.Else, the change could just be reverted.
Relevant log output
Are you a ML Ops Team?
No
What LiteLLM version are you on ?
v1.57.5
Twitter / LinkedIn details
@_EDM115 / https://www.linkedin.com/in/edm115
The text was updated successfully, but these errors were encountered: