Skip to content

Fix __init__ types on Message class #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ryanpeach
Copy link

@ryanpeach ryanpeach commented Jan 8, 2025

Fix init types on Message class

Relevant issues

Fixes #7630

Type

🐛 Bug Fix

Changes

Copy types from the root attributes to the init parameters.

Testing

Does cicd type check?

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 6:35pm

@dblakely
Copy link

dblakely commented Apr 8, 2025

Hey @ryanpeach, any thoughts on merging this? I'm also running into this same issue with mypy while using LiteLLM and this PR would be sweet! 👍

@ryanpeach
Copy link
Author

Hey @ryanpeach, any thoughts on merging this? I'm also running into this same issue with mypy while using LiteLLM and this PR would be sweet! 👍

The PR is open, so now it's out of my hands.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are the __init__ types different than the object attribute types?
3 participants