Refactor view_key_table #7780
Merged
Refactor view_key_table #7780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
merging into staging branch to view changes |
ishaan-jaff
merged commit 8e31b61
into
BerriAI:litellm_ui_staging_jan_15
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Refactor view_key_table
Relevant issues
For handle #6448, #7689 properly, I believe we should almost rewrite view_key_table.tsx and user_dashboard.tsx.
If we build it on right foundation like Tanstack Table, we will be able to support most of things admin want with the data(etc, key) table.
This PR is ongoing effort to do that incrementally.
Type
🧹 Refactoring
Changes
Refactors. Remove dead code, format, and extract modals.