Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bob/fixes #2655

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Bob/fixes #2655

merged 5 commits into from
Jan 22, 2025

Conversation

bob0005
Copy link
Collaborator

@bob0005 bob0005 commented Jan 22, 2025

Summary by CodeRabbit

Based on the comprehensive summary, here are the release notes:

  • Refactoring

    • Updated import sources for leaderboard and hyperstructure hooks across multiple components
    • Simplified dependency management in various modules
    • Removed certain package dependencies in the React package
  • Configuration

    • Added new configuration handling for Eternum application
    • Updated Vite configuration with new path aliases and public directory
  • Chores

    • Cleaned up import statements and module exports
    • Streamlined how configuration and setup are managed in the landing application

These changes primarily focus on internal code organization and dependency management, with minimal direct impact on end-user functionality.

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:13am
eternum-docs ❌ Failed (Inspect) Jan 22, 2025 10:13am
eternum-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:13am

Copy link
Contributor

mentatbot bot commented Jan 22, 2025

Hi @bob0005! You need to be added as a user to interact with me. Please ask @ponderingdemocritus to add you on the settings page.

You are receiving this comment because I am set to review all PRs. That is configurable here.

Copy link
Contributor

coderabbitai bot commented Jan 22, 2025

Caution

Review failed

The pull request is closed.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

client/apps/game/src/hooks/store/use-leaderboard-store.ts

Oops! Something went wrong! :(

ESLint: 9.18.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request introduces a series of modifications across multiple files in the client and packages directories. The changes primarily focus on restructuring import statements, updating configuration handling, and removing certain dependencies. Key modifications include centralizing hook imports, updating environment configurations, adjusting module setups, and removing specific dependencies from the react package. These changes aim to improve code organization, streamline imports, and potentially optimize the application's configuration management.

Changes

File Change Summary
client/apps/game/src/hooks/store/use-leaderboard-store.ts Updated import sources for useDojo and useNextBlockTimestamp
client/apps/game/src/ui/components/hyperstructures/hyperstructure-panel.tsx Modified useHyperstructureData import source
client/apps/game/src/ui/modules/social/end-season-button.tsx Switched useLeaderBoardStore import to local module
client/apps/game/src/ui/modules/social/social.tsx Added new hook imports and updated component logic
client/apps/landing/env.ts Added commented environment variables for Ark Marketplace API
client/apps/landing/src/components/modules/realm-card.tsx Simplified useEffect dependency and useReadContract logic
client/apps/landing/src/components/providers/starknet-provider.tsx Converted resource addresses to strings
client/apps/landing/src/dojo/setup.ts Added ETERNUM_CONFIG import and configuration setup
client/apps/landing/src/hooks/context/DojoContext.tsx Updated import path and controllerAccount handling
client/apps/landing/src/main.tsx Uncommented dojoConfig and setup imports
client/apps/landing/src/utils/config.ts Added ETERNUM_CONFIG async function
client/apps/landing/vite.config.ts Updated alias resolution and public directory path
packages/react/package.json Removed several dependencies
packages/react/src/hooks/index.ts Removed export for store module
packages/react/src/hooks/store/index.ts Removed exports from use-leaderboard-store

Suggested reviewers

  • aymericdelab

Poem

🐰 Hops of Code, Leaps of Change

Imports dance, dependencies rearrange,
Configs whisper secrets anew,
A rabbit's refactor, clean and true!

Modules shift like digital leaves,
Streamlined paths that softly weave 🌿


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8a2dcd and 520267b.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (15)
  • client/apps/game/src/hooks/store/use-leaderboard-store.ts (1 hunks)
  • client/apps/game/src/ui/components/hyperstructures/hyperstructure-panel.tsx (1 hunks)
  • client/apps/game/src/ui/modules/social/end-season-button.tsx (1 hunks)
  • client/apps/game/src/ui/modules/social/social.tsx (2 hunks)
  • client/apps/landing/env.ts (1 hunks)
  • client/apps/landing/src/components/modules/realm-card.tsx (1 hunks)
  • client/apps/landing/src/components/providers/starknet-provider.tsx (1 hunks)
  • client/apps/landing/src/dojo/setup.ts (2 hunks)
  • client/apps/landing/src/hooks/context/DojoContext.tsx (2 hunks)
  • client/apps/landing/src/main.tsx (1 hunks)
  • client/apps/landing/src/utils/config.ts (1 hunks)
  • client/apps/landing/vite.config.ts (2 hunks)
  • packages/react/package.json (0 hunks)
  • packages/react/src/hooks/index.ts (0 hunks)
  • packages/react/src/hooks/store/index.ts (0 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Failed to generate code suggestions for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant