Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD groot normalizer #60

Merged
merged 8 commits into from
Aug 13, 2024

Conversation

Vedanth-Ramji
Copy link
Member

No description provided.

@Vedanth-Ramji Vedanth-Ramji added the WIP work in progress label Jul 27, 2024
@Vedanth-Ramji Vedanth-Ramji marked this pull request as ready for review August 3, 2024 07:29
@Vedanth-Ramji
Copy link
Member Author

I've marked this as ready for review now as the normalizer is out. Once #61 is merged, I'll go ahead and add the tests for groot

@luispedro
Copy link
Member

There are several unanswered comments (I just added a few more)

@Vedanth-Ramji
Copy link
Member Author

Oh, could you please let me know where I could find these comments? I can't find them in my mail or on GitHub.

argnorm/data/manual_curation/groot_curation.tsv Outdated Show resolved Hide resolved
db_harmonisation/get_groot_dbs.sh Outdated Show resolved Hide resolved
argnorm/normalizers.py Outdated Show resolved Hide resolved
db_harmonisation/README.md Outdated Show resolved Hide resolved
@luispedro
Copy link
Member

luispedro commented Aug 4, 2024 via email

@Vedanth-Ramji
Copy link
Member Author

I just updated the readme for db_harmonisation now. Is it ok now?

@Vedanth-Ramji Vedanth-Ramji removed the WIP work in progress label Aug 7, 2024
@luispedro luispedro merged commit 797aed3 into BigDataBiology:main Aug 13, 2024
6 checks passed
@Vedanth-Ramji Vedanth-Ramji deleted the add-groot-normalizer branch August 13, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants