-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD groot normalizer #60
Merged
luispedro
merged 8 commits into
BigDataBiology:main
from
Vedanth-Ramji:add-groot-normalizer
Aug 13, 2024
Merged
ADD groot normalizer #60
luispedro
merged 8 commits into
BigDataBiology:main
from
Vedanth-Ramji:add-groot-normalizer
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've marked this as ready for review now as the normalizer is out. Once #61 is merged, I'll go ahead and add the tests for groot |
There are several unanswered comments (I just added a few more) |
Oh, could you please let me know where I could find these comments? I can't find them in my mail or on GitHub. |
luispedro
requested changes
Aug 4, 2024
…oot always uses latest CARD database
Thanks. I think this context is not clear from the proposed documentation text.
|
I just updated the readme for db_harmonisation now. Is it ok now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.