Open
Conversation
Contributor
egorksv
commented
Jan 2, 2021
egorksv
commented
- No load balancers
- No autoscaling
- Output set to single node IP address
synhershko
reviewed
Jan 2, 2021
synhershko
reviewed
Jan 2, 2021
synhershko
reviewed
Jan 2, 2021
egorksv
force-pushed
the
feature/single-node
branch
4 times, most recently
from
2204189 to
bd1eaf6
Compare
- No load balancers - No autoscaling - Output set to single node IP address fixed issue with singlenode instance being provisioned in clustered mode Single-node network interface attachment to ensure connectivity without load balancer updated gitignore Kibana image restored file file restored
egorksv
force-pushed
the
feature/single-node
branch
from
bd1eaf6 to
9faaeb8
Compare
tsimonyan
reviewed
Jan 17, 2021
| count = local.singlenode_mode ? 0 : 1 | ||
|
|
||
| name = "${var.environment}-${var.es_cluster}-alb" | ||
| internal = ! var.public_facing |
Contributor
There was a problem hiding this comment.
The variable public_facing is not accounted anymore for single-nodes.
| #!/bin/bash | ||
| set +e | ||
|
|
||
| echo "Testing AMI Builder if it works properly" |
| }) | ||
| } | ||
|
|
||
| resource "aws_network_interface" "single_node" { |
Contributor
There was a problem hiding this comment.
Has to be conditional, only created when singlenode_mode is true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.