Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic tests for KetlCred #38

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add basic tests for KetlCred #38

merged 1 commit into from
Jul 12, 2023

Conversation

wilsonplau
Copy link
Contributor

@wilsonplau wilsonplau commented Jul 12, 2023 •
edited
Loading

  • Adds KetlAttestationContract mock using waffle
  • Changes testing setup to better match up with SealCred Ledger contracts
  • Adds tests for KetlCred-related functionality

@wilsonplau wilsonplau marked this pull request as ready for review July 12, 2023 13:53
@wilsonplau wilsonplau mentioned this pull request Jul 12, 2023
Closed
wilsonplau
wilsonplau commented Jul 12, 2023
View reviewed changes
test/OBSSStorage.ketlkred.spec.ts
this.fakeKetlAttestationContract.address,
0,
this.owner.address,
])) as Profiles
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This as is still needed because upgrades.deployProxy still doesn't support generics: OpenZeppelin/openzeppelin-upgrades#535

wilsonplau
wilsonplau commented Jul 12, 2023
View reviewed changes
test/utils/fakes.ts
export async function getFakeKetlAttestationContract(
signer: SignerWithAddress
) {
return await deployMockContract(signer, [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider importing contract ABI from ketl-attestation-contract

@wilsonplau wilsonplau merged commit 587b0e8 into ketl-cred-upvotes-only Jul 12, 2023
@wilsonplau wilsonplau deleted the contract-test-setup branch July 12, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wilsonplau