Cbracy adding comment from tom #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion via converation with Tom in morning meeting
|
Thanks @connorjbracy . We already merged a PR from Kevin fixing this (#35). Is this still needed or the merged fix is enough? tbh a bit more documentation would be good, perhaps in the form of informational messages to users letting them know whether latex was found and if not that we can't guarantee the angstrom signs will look good etc., but just let me know if I should merge this or it is out of date. |
|
@connorjbracy ping on this. Let me know if we can close this. I think it is all merged and rereleased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue of "LaTeX library/function X not found" has come up several times causing issues with using the stylesheet on various OS distributions. I've added a comment from a conversation we had with tcaswell in a morning meeting regarding this from a couple of weeks ago.