Sam PR #2
Sam PR #2
Conversation
There was a problem hiding this comment.
@8bitsam, not sure what is going on here, but it looks a bit like Tieqiong's PR that is way too long to ever possibly review and merge. Please can you work with Tieqiiong and possibly Yucong to get the group coding workflows better under control.
Let's use a forking workflow (as usual) on this repo and make much ore granular PRs. Tieqiong is also learning this workflow and I asked if he could work with Yucong to go through it. To save her time, please can you arrange to do it together. Thanks so much.
S
|
Simon closing htis. Please see comments in the review, and also comments in the PR from tieqiong |
|
Sorry about the confusion, the original PR had many smaller commits and made granular edits, but was in referece to the unmerged NSLS-II cookie cutter, so it may look cluttered. I copied this branch over from the other repository for convenience so the changes made would still be available as a branch on this repository. |
|
Ok, gotcha
…On Wed, Jun 19, 2024, 8:14 AM Sparky ***@***.***> wrote:
Sorry about the confusion, the original PR had many smaller commits and
made granular edits. I copied this branch over from the other repository
for convenience so the changes made would still be available as a branch on
this repository.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUJEKN3OY7SAPRZPHWTZIFYZHAVCNFSM6AAAAABJQ4JBBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZYGU2DOOBXGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
No description provided.