Update pyproject.toml, remove setup.py #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please could you redo this PR on a clean main? thnks so much.... Sorry for the hassles. |
|
I think it should be otherwise up to date with main now. |
|
yes, but there is a dirty merge of main. Normally, never merge main unless
there is a good reason to. We do it the other way around (we merge the
branches into main).
So just close this PR and make a new one from a clean main. There has been
a bunch of cleaning going on which is one reason this is happening.
S
…On Wed, Jun 19, 2024 at 5:41 PM Sam Andrello ***@***.***> wrote:
I think it should be otherwise up to date with main now.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUKNF3Z6TKWHKTQHKBDZIH3HVAVCNFSM6AAAAABJSMNOTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGQ4DSMJRG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Simon Billinge
Professor,
Department of Applied Physics and Applied Mathematics
Columbia University
|
|
Alright, will do this for my other PR too. |
|
yes, thanks. git hygiene.....
…On Wed, Jun 19, 2024 at 6:05 PM Sam Andrello ***@***.***> wrote:
Alright, will do this for my other PR too.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUIGTBVAQ5MOXVN427TZIH6CRAVCNFSM6AAAAABJSMNOTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGUYDQOJSGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Simon Billinge
Professor,
Department of Applied Physics and Applied Mathematics
Columbia University
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
Replaces setup.py in package root dir with pyproject.toml.