Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit-config.yaml #36

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Update pre-commit-config.yaml #36

merged 2 commits into from
Jun 19, 2024

Conversation

sbillinge
Copy link
Collaborator

closes #9

@sbillinge
Copy link
Collaborator Author

Git diff check:
image

@sbillinge
Copy link
Collaborator Author

per @Sparks29032 comment in the issue, changing the name to .yml from .yaml prevents cookiecutter from finding it. it may be fixable, but I suggest it is not worth the bother. Let's stick with yaml.

@Sparks29032
Copy link
Collaborator

Got it! Merge? Seems good

@sbillinge
Copy link
Collaborator Author

Yes, I'm good to merge this.

How can we trigger pre-commit in the CI on the cookiecutter repo? Do we want to do that? I don't think there are any other tests we want to run on CI

@Sparks29032
Copy link
Collaborator

I think I put in a request to add the CI for pre-commit (not sure where that request goes though), but yea, matches with the original repo probably mean the pre-commit operations are done

@sbillinge
Copy link
Collaborator Author

sbillinge commented Jun 19, 2024 via email

@Sparks29032
Copy link
Collaborator

Sparks29032 commented Jun 19, 2024

I think you have to do something in the project settings maybe to enable it since I didn't have permissions to add it, just to send in a request

It could be at this link?

@Sparks29032
Copy link
Collaborator

Sparks29032 commented Jun 19, 2024

pre-commit.ci run

@sbillinge
Copy link
Collaborator Author

OK, I will merge this to get the changes and we can work on getting it to pass other things.

@sbillinge sbillinge merged commit c41b13b into main Jun 19, 2024
1 check failed
@sbillinge sbillinge deleted the pre-commit-yaml branch June 19, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.pre-commit-config.yaml
2 participants