Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance carinfo display #858

Merged
merged 3 commits into from
Feb 15, 2025
Merged

Enhance carinfo display #858

merged 3 commits into from
Feb 15, 2025

Conversation

SteWers
Copy link
Contributor

@SteWers SteWers commented Feb 5, 2025

In this PR I did several things:

  • add a travel overview to the carinfo display
  • workaround for parking brake, if parkingBrakeSet is empty
  • clean up g-forces
  • a bit code rework and formatting

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 52.17391% with 22 lines in your changes missing coverage. Please review.

Project coverage is 42.41%. Comparing base (2f8e3c9) to head (7415a23).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ndroidautoidrive/carapp/carinfo/CarDetailedInfo.kt 57.69% 11 Missing ⚠️
...java/me/hufman/androidautoidrive/cds/CDSMetrics.kt 31.25% 9 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #858      +/-   ##
============================================
+ Coverage     41.07%   42.41%   +1.34%     
- Complexity     1511     1513       +2     
============================================
  Files           263      256       -7     
  Lines         14425    13948     -477     
  Branches       2548     2486      -62     
============================================
- Hits           5925     5916       -9     
+ Misses         7382     6925     -457     
+ Partials       1118     1107      -11     
Files with missing lines Coverage Δ
.../main/java/me/hufman/androidautoidrive/carapp/L.kt 86.82% <100.00%> (+0.32%) ⬆️
...ndroidautoidrive/carapp/carinfo/CarDetailedInfo.kt 71.95% <57.69%> (-3.23%) ⬇️
...java/me/hufman/androidautoidrive/cds/CDSMetrics.kt 45.94% <31.25%> (+1.50%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f8e3c9...7415a23. Read the comment docs.

app/build.gradle Outdated Show resolved Hide resolved
@hufman
Copy link
Collaborator

hufman commented Feb 15, 2025

I sincerely apologize for the delay! I tested just now and it looks great, thank you so much!

@hufman hufman merged commit 7963088 into BimmerGestalt:main Feb 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants