Skip to content
This repository has been archived by the owner on Nov 19, 2023. It is now read-only.

Commit

Permalink
dep updates
Browse files Browse the repository at this point in the history
  • Loading branch information
@tib
tib committed Dec 14, 2021
1 parent 18bb4db commit a5d133d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Package.resolved
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"repositoryURL": "https://github.com/binarybirds/liquid-kit.git",
"state": {
"branch": null,
"revision": "3edb219664e764c4cf08658195f2f7dd552e3207",
"version": "1.3.0"
"revision": "48cda11e866ffe1de98f862406819f8f5ccfb97f",
"version": "1.3.2"
}
},
{
Expand Down
6 changes: 3 additions & 3 deletions Package.swift
View file
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
// swift-tools-version:5.3
// swift-tools-version:5.5
import PackageDescription

let package = Package(
name: "liquid",
platforms: [
.macOS(.v10_15)
.macOS(.v12)
],
products: [
.library(name: "Liquid", targets: ["Liquid"]),
],
dependencies: [
.package(url: "https://github.com/vapor/vapor.git", from: "4.50.0"),
.package(url: "https://github.com/binarybirds/liquid-kit.git", from: "1.3.0"),
.package(url: "https://github.com/binarybirds/liquid-kit.git", from: "1.3.2"),
],
targets: [
.target(name: "Liquid", dependencies: [
Expand Down

6 comments on commit a5d133d

@mkll
Copy link

@mkll mkll commented on a5d133d Dec 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tib Hi, is it really necessary to set minimum macOS version to .macOS(.v12), while:

  1. Vapor, the "parent" package for Liquid, still supports .macOS(.v10_15)

  2. Swift 5.5 (Xcode 13.2) allows using "Swift Concurrency in applications that deploy to macOS Catalina 10.15, iOS 13, tvOS 13, and watchOS 6 or newer. This support includes async/await, actors, global actors, structured concurrency, and the task APIs."

@mkll
Copy link

@mkll mkll commented on a5d133d Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you ever try to build Vapor with such minimum version settings? It's impossible due to version mismatch.

@tib
Copy link
Member Author

@tib tib commented on a5d133d Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try with 10_15, I’ll check tomorrow. 😉

@mkll
Copy link

@mkll mkll commented on a5d133d Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it doesn't compile at all, fails after package versions resolving. ;)
The same for other repos that you updated today.

@tib
Copy link
Member Author

@tib tib commented on a5d133d Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the platform dependency to 10.15, it worked for me, could you confirm it too?

@mkll
Copy link

@mkll mkll commented on a5d133d Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are no macOS version mismatch errors anymore.
Thanks!

Please sign in to comment.