Added a findOverlap method for character vectors.#60
Open
LTLA wants to merge 1 commit intoBioconductor:develfrom
Open
Added a findOverlap method for character vectors.#60LTLA wants to merge 1 commit intoBioconductor:develfrom
LTLA wants to merge 1 commit intoBioconductor:develfrom
Conversation
Contributor
|
Would this also handle character representation of ranges, like "chr1:1-1000"? |
Author
|
Not as implemented. An alternative approach would to coerce character vectors to a |
Author
|
Any thoughts about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52 with the following syntactic sugar:
Also works for GRLs:
maxgapandminoverlapare currently ignored completely.typeis mostly ignored except for the GRL methods, which require all ranges in a GRL element to lie within the sequence name to consider an overlap with that name.Note that
overlapsAnyand friends don't yet work out of the box; I'm guessing aVector_OR_vectorsignature needs to be added to the methods so that it can pass along the character vectors properly.