Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer coloring for light and dark theme #3359

Merged
merged 4 commits into from
Jan 19, 2025
Merged

Clearer coloring for light and dark theme #3359

merged 4 commits into from
Jan 19, 2025

Conversation

ProtagNeptune
Copy link
Contributor

@ProtagNeptune ProtagNeptune commented Jan 11, 2025 •
edited
Loading

image
image

@ProtagNeptune ProtagNeptune changed the title Update options-window.cpp Clearer coloring for light and dark theme Jan 11, 2025
@ProtagNeptune ProtagNeptune mentioned this pull request Jan 11, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 32.77%. Comparing base (b984bfa) to head (b8cb659).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop    #3359    +/-   ##
=========================================
  Coverage    32.77%   32.77%            
=========================================
  Files          384      384            
  Lines        24178    24178            
  Branches      3548     3548            
=========================================
  Hits          7924     7924            
- Misses       16136    16253   +117     
+ Partials       118        1   -117

@Bionus Bionus force-pushed the develop branch 2 times, most recently from 6bc94e1 to 23c8279 Compare January 19, 2025 01:08
@Bionus Bionus self-requested a review January 19, 2025 01:15
Bionus
Bionus approved these changes Jan 19, 2025
View reviewed changes
Copy link
Owner

@Bionus Bionus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for the CI to pass to merge 👍

@Bionus Bionus added the ui label Jan 19, 2025
@Bionus Bionus merged commit da3559b into Bionus:develop Jan 19, 2025
11 of 12 checks passed
@ProtagNeptune ProtagNeptune deleted the patch-1 branch January 19, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bionus Bionus Bionus approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ProtagNeptune @Bionus