Open
Conversation
…TNATION-Pangea-mobile into feature/ui-release
…TNATION-Pangea-mobile into feature/ui-release
This reverts commit 18027ad.
…Pangea-mobile into feature/ui-release
…Pangea-mobile into feature/ui-release
marknuzz
reviewed
Mar 14, 2019
| if (err) { | ||
| return console.log('something went wrong loading', err); | ||
| } | ||
| t('hi'); // -> same as i18next.t |
Contributor
There was a problem hiding this comment.
@hunght in case anyone was affected by this bug, they will already have their language setting stuck on 'hi' and they will still be unable to switch back to 'en'. Can you simply change this to the way it was before but instead of 'hi' use 'en'. That way, anyone who was affected will get the 'en' back. When we actually have support for the other languages we can remove that code.
Contributor
|
Looks good, any way we can get tests to pass? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed
1/ language
2/ seed phrase screen