Skip to content

Commit

Permalink
OP-448 - Remove session service
Browse files Browse the repository at this point in the history
  • Loading branch information
JanPalen committed Aug 1, 2024
1 parent 2308225 commit ba831e5
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ jobs:
name: Prepare test application assets
run: |
(cd tests/Application && bin/console assets:install public -vvv)
(cd tests/Application && yarn add encore dev)
(cd tests/Application && yarn encore dev)
-
name: Prepare test application cache
Expand Down
1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"friends-of-behat/suite-settings-extension": "^1.0",
"friends-of-behat/symfony-extension": "^2.1",
"friends-of-behat/variadic-extension": "^1.3",
"friendsofsymfony/oauth-server-bundle": "^1.6 || >2.0.0-alpha.0 ^2.0@dev",
"lakion/mink-debug-extension": "^2.0.0",
"phpspec/phpspec": "^7.0",
"phpstan/extension-installer": "^1.0",
Expand Down
7 changes: 6 additions & 1 deletion src/Action/NotifyAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
use Payum\Core\Reply\HttpResponse;
use Payum\Core\Request\GetHttpRequest;
use Payum\Core\Request\Notify;
use Psr\Log\LoggerInterface;
use SM\Factory\FactoryInterface;
use Sylius\Bundle\PayumBundle\Model\GatewayConfigInterface;
use Sylius\Component\Core\Model\OrderInterface;
Expand All @@ -32,11 +33,15 @@ final class NotifyAction implements ActionInterface, ApiAwareInterface, GatewayA
{
use GatewayAwareTrait, ApiAwareTrait;

/** @var LoggerInterface */
private $logger;

Check failure on line 37 in src/Action/NotifyAction.php

View workflow job for this annotation

GitHub Actions / Sylius ~1.12.0, PHP 8.3, Symfony ^5.4, MySQL 8.0

Property BitBag\SyliusMultiSafepayPlugin\Action\NotifyAction::$logger is never read, only written.

Check failure on line 37 in src/Action/NotifyAction.php

View workflow job for this annotation

GitHub Actions / Sylius ~1.13.0, PHP 8.3, Symfony ^5.4, MySQL 8.0

Property BitBag\SyliusMultiSafepayPlugin\Action\NotifyAction::$logger is never read, only written.

Check failure on line 37 in src/Action/NotifyAction.php

View workflow job for this annotation

GitHub Actions / Sylius ~1.13.0, PHP 8.1, Symfony ^5.4, MySQL 8.0

Property BitBag\SyliusMultiSafepayPlugin\Action\NotifyAction::$logger is never read, only written.

Check failure on line 37 in src/Action/NotifyAction.php

View workflow job for this annotation

GitHub Actions / Sylius ~1.12.0, PHP 8.0, Symfony ^5.4, MySQL 8.0

Property BitBag\SyliusMultiSafepayPlugin\Action\NotifyAction::$logger is never read, only written.

Check failure on line 37 in src/Action/NotifyAction.php

View workflow job for this annotation

GitHub Actions / Sylius ~1.12.0, PHP 8.2, Symfony ^5.4, MySQL 8.0

Property BitBag\SyliusMultiSafepayPlugin\Action\NotifyAction::$logger is never read, only written.

Check failure on line 37 in src/Action/NotifyAction.php

View workflow job for this annotation

GitHub Actions / Sylius ~1.12.0, PHP 8.1, Symfony ^5.4, MySQL 8.0

Property BitBag\SyliusMultiSafepayPlugin\Action\NotifyAction::$logger is never read, only written.

Check failure on line 37 in src/Action/NotifyAction.php

View workflow job for this annotation

GitHub Actions / Sylius ~1.13.0, PHP 8.2, Symfony ^5.4, MySQL 8.0

Property BitBag\SyliusMultiSafepayPlugin\Action\NotifyAction::$logger is never read, only written.

/** @var FactoryInterface */
private $stateMachineFactory;

public function __construct(FactoryInterface $stateMachineFactory)
public function __construct(LoggerInterface $logger, FactoryInterface $stateMachineFactory)
{
$this->logger = $logger;
$this->stateMachineFactory = $stateMachineFactory;
}

Expand Down
1 change: 0 additions & 1 deletion src/Resources/config/services.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<service id="bitbag_sylius_multisafepay_plugin.api_client.multisafepay_api_client" class="BitBag\SyliusMultiSafepayPlugin\ApiClient\MultiSafepayApiClient" public="true" />

<service id="bitbag_sylius_multisafepay_plugin.payment_processing.refund" class="BitBag\SyliusMultiSafepayPlugin\PaymentProcessing\RefundPaymentProcessor" public="true">
<argument type="service" id="session" />
<argument type="service" id="bitbag_sylius_multisafepay_plugin.api_client.multisafepay_api_client" />
<argument type="service" id="monolog.logger.payum" />
</service>
Expand Down

0 comments on commit ba831e5

Please sign in to comment.